Fix validation of block-list when used without policy
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `block-list` isn't set in the workflow file and policy isn't used. Validation will fail because the block list is `['']` when undefined. This commit is a nasty hack and should be replaced with proper validation using zod library.
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 84.06% 83.88% -0.19%
==========================================
Files 5 5
Lines 502 515 +13
Branches 97 99 +2
==========================================
+ Hits 422 432 +10
- Misses 80 83 +3
|
jamacku
changed the title
block-list when used without policyblock-list when used without policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
block-listisn't set in the workflow file and policy isn't used. Validation will fail because the block list is['']when undefined.This commit is a nasty hack and should be replaced with proper validation using zod library.