refactor(test): add labeler.ts tests

redhat-plumbers-in-action · Apr 19, 2024 · 4f6ecc9 · 4f6ecc9
1 parent 58689c0
commit 4f6ecc9
Show file tree

Hide file tree

Showing 5 changed files with 302 additions and 71 deletions.
diff --git a/test/unit/config.fixture.ts b/test/unit/config.fixture.ts
@@ -0,0 +1,54 @@
+export const emptyConfig = {};
+
+export const basicConfig = {
+  policy: [
+    {
+      section: [
+        {
+          id: ['type'],
+          label: [
+            { name: 'bug 🐛', keys: ['Bug Report'] },
+            { name: 'RFE 🎁', keys: ['Feature Request'] },
+          ],
+        },
+      ],
+    },
+  ],
+};
+
+export const templateConfig = {
+  policy: [
+    {
+      template: ['bug.yml', 'feature.yml'],
+      section: [
+        {
+          id: ['type'],
+          label: [
+            { name: 'bug 🐛', keys: ['Bug Report'] },
+            { name: 'RFE 🎁', keys: ['Feature Request'] },
+          ],
+        },
+        {
+          id: ['severity'],
+          label: [
+            { name: 'high', keys: ['High'] },
+            { name: 'medium', keys: ['Medium'] },
+            { name: 'low', keys: ['Low'] },
+          ],
+        },
+      ],
+    },
+    {
+      template: ['custom.yml'],
+      section: [
+        {
+          id: ['type'],
+          label: [
+            { name: 'custom1', keys: ['Custom 1'] },
+            { name: 'custom2', keys: ['Custom 2'] },
+          ],
+        },
+      ],
+    },
+  ],
+};
diff --git a/test/unit/config.test.ts b/test/unit/config.test.ts
@@ -2,55 +2,10 @@ import { describe, expect, test } from 'vitest';
 
 import { Config } from '../../src/config';
 
-const emptyConfig = {};
-
-const basicConfig = {
-  policy: [
-    {
-      section: [
-        {
-          id: ['type'],
-          label: [
-            { name: 'bug 🐛', keys: ['Bug Report'] },
-            { name: 'RFE 🎁', keys: ['Feature Request'] },
-          ],
-        },
-      ],
-    },
-  ],
-};
-
-const templateConfig = {
-  policy: [
-    {
-      template: ['bug.yml', 'feature.yml'],
-      section: [
-        {
-          id: ['type'],
-          label: [
-            { name: 'bug 🐛', keys: ['Bug Report'] },
-            { name: 'RFE 🎁', keys: ['Feature Request'] },
-          ],
-        },
-      ],
-    },
-    {
-      template: ['custom.yml'],
-      section: [
-        {
-          id: ['type'],
-          label: [
-            { name: 'custom1', keys: ['Custom 1'] },
-            { name: 'custom2', keys: ['Custom 2'] },
-          ],
-        },
-      ],
-    },
-  ],
-};
+import { basicConfig, emptyConfig, templateConfig } from './config.fixture';
 
 describe('Test Config class', () => {
-  test('Config class is defined', () => {
+  test('smoke test', () => {
     const config = new Config(basicConfig, '.github/issue-labeler.yml');
 
     expect(config.policy).toMatchInlineSnapshot(`
@@ -201,6 +156,32 @@ describe('Test Config class', () => {
                 },
               ],
             },
+            {
+              "block-list": [],
+              "id": [
+                "severity",
+              ],
+              "label": [
+                {
+                  "keys": [
+                    "High",
+                  ],
+                  "name": "high",
+                },
+                {
+                  "keys": [
+                    "Medium",
+                  ],
+                  "name": "medium",
+                },
+                {
+                  "keys": [
+                    "Low",
+                  ],
+                  "name": "low",
+                },
+              ],
+            },
           ],
           "template": [
             "bug.yml",

diff --git a/test/unit/issue-form.fixture.ts b/test/unit/issue-form.fixture.ts
@@ -0,0 +1,14 @@
+export const emptyForm = {};
+
+export const basicForm = {
+  title: 'Test issue',
+  body: 'Test body',
+};
+
+export const dropdownForm = {
+  title: 'Test issue',
+  body: 'Test body',
+  severity: 'High',
+  type: 'Bug Report, Feature Request, other, none',
+  checkList: ['one', 'two', 'three'],
+};
diff --git a/test/unit/issue-form.test.ts b/test/unit/issue-form.test.ts
@@ -1,24 +1,10 @@
 import { describe, expect, test } from 'vitest';
 
 import { IssueForm } from '../../src/issue-form';
-
-const emptyForm = {};
-
-const basicForm = {
-  title: 'Test issue',
-  body: 'Test body',
-};
-
-const dropdownForm = {
-  title: 'Test issue',
-  body: 'Test body',
-  severity: 'high',
-  multiDropdown: 'one, two, other, none',
-  checkList: ['one', 'two', 'three'],
-};
+import { basicForm, dropdownForm } from './issue-form.fixture';
 
 describe('Test IssueForm class', () => {
-  test('IssueForm class is defined', () => {
+  test('smoke test', () => {
     const issueForm = new IssueForm(basicForm);
 
     expect(issueForm.parsed).toMatchInlineSnapshot(`
@@ -43,7 +29,7 @@ describe('Test IssueForm class', () => {
       `"Test issue"`
     );
     expect(issueForm.getSafeProperty('severity')).toMatchInlineSnapshot(
-      `"high"`
+      `"High"`
     );
     expect(issueForm.getSafeProperty('nonexistent')).toBeUndefined();
   });
@@ -53,17 +39,17 @@ describe('Test IssueForm class', () => {
 
     expect(issueForm.listKeywords('severity', ['none'])).toMatchInlineSnapshot(`
       [
-        "high",
+        "High",
       ]
     `);
 
-    expect(issueForm.listKeywords('multiDropdown', ['other', 'none']))
+    expect(issueForm.listKeywords('type', ['other', 'none']))
       .toMatchInlineSnapshot(`
-      [
-        "one",
-        "two",
-      ]
-    `);
+        [
+          "Bug Report",
+          "Feature Request",
+        ]
+      `);
 
     // Checklists are unsupported at the moment
     expect(issueForm.listKeywords('checkList', [])).toBeUndefined();