Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] quads-web ordered links on dynamic navbar #525

Closed
grafuls opened this issue Sep 25, 2024 · 2 comments
Closed

[RFE] quads-web ordered links on dynamic navbar #525

grafuls opened this issue Sep 25, 2024 · 2 comments

Comments

@grafuls
Copy link
Contributor

grafuls commented Sep 25, 2024

Is your feature request related to a problem? Please describe.
There is no ordering on the way that the links are displayed when being picked up by the dynamic navbar generation.

Describe the solution you'd like
Add some logic to the dynamic navbar generation to expect an integer prefix on the file names with the index for the order like:

01_this.html
02_that.html
...
nn_last.html

Describe alternatives you've considered
Alternatively we can keep the file names as are and have the dynamic bar generation look for a .order file with the required order for the links.

@sadsfae
Copy link
Member

sadsfae commented Sep 25, 2024

I think the ordering prefix is cleaner because we don't need to manage another file. Also, behavior-wise if items don't have it then they can just land where they land.

@sadsfae sadsfae added this to the 2.0 Series - Bowie milestone Sep 25, 2024
sadsfae added a commit that referenced this issue Sep 25, 2024
* Modify version and RPM spec to point to 2.1 branch
* Add minor '%' after Daily utilization
* A few more features may be added like:
  - #525
  - #524

Change-Id: Id98f37ae211e1a3dea8d99841ad0e0e499a99a99
sadsfae pushed a commit that referenced this issue Sep 26, 2024
The order of menu elements is builtins, followed by
submenus, followed by html and direct link files.

For submenus, you can name them using numerical prefixes.
For example, if you have in /opt/quads/web:

   1_Tickets
   2_Docs
   Foo
   Bar

The submenus will be named:

   Tickets
   Docs
   Bar
   Foo

with the numbered elements listed first, sorted and numbers
stripped off, followed by the unnumbered elements also sorted
but being listed after the numbered submenus

Within each menu, the same logic is used to sort the html
and direct links.

Fixes: #525
Change-Id: I1d9c22969531ad44b68f796852c6d313a4ab6c4f
@sadsfae
Copy link
Member

sadsfae commented Sep 26, 2024

This is resolved in 28613db

@sadsfae sadsfae closed this as completed Sep 26, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in QUADS 2.1 Series Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants