Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notify.py prematurely sends released notifications #317

Closed
sadsfae opened this issue Mar 2, 2020 · 2 comments
Closed

notify.py prematurely sends released notifications #317

sadsfae opened this issue Mar 2, 2020 · 2 comments
Labels
bug notifications validation
Milestone
2.x Series - Bowie

Comments

@sadsfae
Copy link
Member

sadsfae commented Mar 2, 2020 •
edited
Loading

  • QUADS version : quads-1.1.2-20200122.noarch
  • Python version: 3.7
  • Operating System: Fedora 29

Describe the bug
This behavior is partly captured here and related:

#307

We are seeing notify.py send out premature released notifications to users before assignments have actually completed their validation workflow.

This seems to occur right at 22:00 UTC when the assignment starts to be provisioned, but the assignments wiki does show they are not released yet and still validating.
@sadsfae sadsfae added this to the 1.2 Series milestone Mar 2, 2020
@sadsfae
Copy link
Member Author

sadsfae commented Mar 2, 2020

Potentially fixed here: https://review.gerrithub.io/c/redhat-performance/quads/+/486192

@sadsfae sadsfae closed this as completed in 5d75146 Mar 2, 2020
sadsfae pushed a commit that referenced this issue Mar 10, 2020
@grafuls
fix: early notifications
3403443 
when running notify.py we are checking for validated clouds but old
clouds that moved back to default cloud remained validated.
added logic to move old clouds back to validated=False.

Closes: #317
Change-Id: I09614cb58628b38b428af265241cc619765806ae
@sadsfae
Copy link
Member Author

sadsfae commented Mar 30, 2020

I am re-opening this, we're still seeing this behavior.

@sadsfae sadsfae reopened this Mar 30, 2020
@sadsfae sadsfae closed this as completed in 31fee10 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug notifications validation
Projects
No open projects
QUADS 1.1 and 2.0 Series
Status: Done
Milestone
2.x Series - Bowie
Development

No branches or pull requests
1 participant
@sadsfae