Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an additional validation for public IP address requirement #192

Closed
sadsfae opened this issue Oct 30, 2018 · 2 comments
Closed

Create an additional validation for public IP address requirement #192

sadsfae opened this issue Oct 30, 2018 · 2 comments

Comments

@sadsfae
Copy link
Member

sadsfae commented Oct 30, 2018

This covers augmenting quads-cli --define-cloud with an optional argparse value like --extnet true (default being false) that should create a stub file (via subprocess or similar) that holds up release of an assignment until a public VLAN can be deployed on the 4th interface of the hosts.

This will then correspond to a validation check that will gate release if the stub file is present.

This should land somewhere around here in the validations:

https://github.com/redhat-performance/quads/blob/master/bin/quads-validate-env.sh#L158

The subsequent notification email for failing this test should contain verbage that there's a requirement for additional public VLAN in which operator action hasn't been taken.

Why are we doing this?

  • We need a way to roll out public VLANs along with assignments that need them at the same time
  • We intend to fully automate this in 1.1 but need something now
  • This should be a minimally invasive change.
@sadsfae
Copy link
Member Author

sadsfae commented Nov 8, 2018

We should include a separate data structure here to track VLAN usage and also automate wiki regeneration, e.g.

cat /opt/quads/conf/vlans.yml
---
pubnet01:
  - id: 1
  - vlanid: 601
  - iprange: 10.12.80.0/23
  - netmask: 255.255.254.0
  - gateway: 10.12.81.254
  - ipfree: 510
  - owner: abond
  - ticket: 435354
  - cloud: 20
pubnet02:
  - id: 2
  - vlanid: 602
  - iprange: 10.12.82.0/23
  - netmask: 255.255.254.0
  - gateway: 10.12.83.254
  - ipfree: 510
  - owner: abond
  - ticket: 434354
  - cloud: 16

@grafuls
Copy link
Contributor

grafuls commented Nov 8, 2018

sadsfae pushed a commit that referenced this issue Feb 13, 2019
"extnet" key might not be present in data. This was causing the
whole logic for creating the vlan stub files to be skipped.
Additionally the values of the fields inside data are being inside
lists so getting first element on list.

Related-to: #192

Change-Id: Iee97a2d33aa5699c7a2cdab1ab69c8ee4207f9b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants