Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERFSCALE-3634] Move to new QUADSv2 URLs #585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josecastillolema
Copy link
Collaborator

No description provided.

@openshift-ci openshift-ci bot requested review from radez and rsevilla87 December 23, 2024 09:14
@josecastillolema josecastillolema removed the request for review from radez December 23, 2024 09:14
Copy link

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josecastillolema

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josecastillolema josecastillolema requested review from akrzos and removed request for rsevilla87 December 23, 2024 09:14
@josecastillolema
Copy link
Collaborator Author

/test ?

Copy link

openshift-ci bot commented Dec 23, 2024

@josecastillolema: The following commands are available to trigger required jobs:

/test deploy-5nodes
/test deploy-5nodes-dev
/test deploy-sno
/test deploy-sno-dev

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@josecastillolema
Copy link
Collaborator Author

/test deploy-sno

Copy link

openshift-ci bot commented Dec 23, 2024

@josecastillolema: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/deploy-sno 4eb7790 link true /test deploy-sno

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@josecastillolema
Copy link
Collaborator Author

josecastillolema commented Dec 23, 2024

TASK [create-inventory : Download ocpinventory.json] ***************************
Monday 23 December 2024  04:20:23 -0500 (0:00:00.020)       0:00:00.385 ******* 
fatal: [localhost]: FAILED! => {"changed": false, "content": "", "elapsed": 0, "msg": "Status code was -1 and not [200]: Request failed: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:897)>", "redirected": false, "status": -1, "url": "https://quads2.rdu3.labs.perfscale.redhat.com/instack/cloud19_ocpinventory.json"}

@akrzos how are you handling certificates for scalelab QUADSv2 URL?
Would using insecure=true here be acceptable?

Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're more changes required.

These tasks are not necessary anymore:

- name: Get VLAN info from performancelab quads
shell: |
set -o pipefail
curl -sk https://wiki.rdu3.labs.perfscale.redhat.com/vlans/ | grep -B7 {{ lab_cloud }} | sed -E 's#</?td>##g'| tr '\n' ' ' | column -J --table-columns vlan_id,cidr,netmask,gateway,ipfree,owner,ticket,cloud
register: vlan_info
when: lab == "performancelab"
- name: Public performancelab VLAN - Set addressing information
set_fact:
controlplane_network: "{{ (vlan_info.stdout | from_json).table[0].cidr }}"
controlplane_network_prefix: "{{ (vlan_info.stdout | from_json).table[0].cidr | ipaddr('prefix') }}"
controlplane_network_gateway: "{{ (vlan_info.stdout | from_json).table[0].gateway }}"
cluster_name: "vlan{{ (vlan_info.stdout | from_json).table[0].vlan_id }}"
when: lab == "performancelab"

These conditionals need to be updated to include performancelab too:

@akrzos
Copy link
Member

akrzos commented Dec 23, 2024

@akrzos how are you handling certificates for scalelab QUADSv2 URL?
Would using insecure=true here be acceptable?

I actually use the override almost all the the time due to machines and requirements for my testing, I think we can just put http in the url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants