-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERFSCALE-3634] Move to new QUADSv2 URLs #585
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jose Castillo Lema <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josecastillolema The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@josecastillolema: The following commands are available to trigger required jobs:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test deploy-sno |
@josecastillolema: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@akrzos how are you handling certificates for scalelab QUADSv2 URL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There're more changes required.
These tasks are not necessary anymore:
jetlag/ansible/roles/create-inventory/tasks/main.yml
Lines 69 to 82 in a5b2bf5
- name: Get VLAN info from performancelab quads | |
shell: | | |
set -o pipefail | |
curl -sk https://wiki.rdu3.labs.perfscale.redhat.com/vlans/ | grep -B7 {{ lab_cloud }} | sed -E 's#</?td>##g'| tr '\n' ' ' | column -J --table-columns vlan_id,cidr,netmask,gateway,ipfree,owner,ticket,cloud | |
register: vlan_info | |
when: lab == "performancelab" | |
- name: Public performancelab VLAN - Set addressing information | |
set_fact: | |
controlplane_network: "{{ (vlan_info.stdout | from_json).table[0].cidr }}" | |
controlplane_network_prefix: "{{ (vlan_info.stdout | from_json).table[0].cidr | ipaddr('prefix') }}" | |
controlplane_network_gateway: "{{ (vlan_info.stdout | from_json).table[0].gateway }}" | |
cluster_name: "vlan{{ (vlan_info.stdout | from_json).table[0].vlan_id }}" | |
when: lab == "performancelab" |
These conditionals need to be updated to include performancelab too:
I actually use the override almost all the the time due to machines and requirements for my testing, I think we can just put http in the url. |
No description provided.