Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing icons #1168

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Conversation

garrett
Copy link
Contributor

@garrett garrett commented Feb 14, 2018

I think these are from the MediaWiki days (many years ago).

Nevertheless, they're referenced in CSS and causing 404s. So I've added them back.

I'm not sure if any pages actually use the styles, but here they are.

@garrett
Copy link
Contributor Author

garrett commented Feb 14, 2018

Added icons to fix a few 404s in #1074.

@mary-grace
Copy link
Contributor

@duck-rh @mscherer @rbowen - could one of the three of you look at this please? I'm sure everything's ok, but just want a gut check from others who know the site far better than I :)

@rbowen
Copy link
Contributor

rbowen commented Feb 15, 2018

I'm not understanding why we're adding icons that aren't actually used anywhere, but, on the other hand, it certainly doesn't appear to break anything, so I guess it looks ok to me.

@mary-grace
Copy link
Contributor

if they truly aren't used anywhere, can we change the CSS instead?

@mscherer
Copy link
Contributor

I would be of @mary-grace opinion of cleaning if I was sure they were unused.
But I do not know enough css to tell what is going on. It seems they are used with some url matching, so maybe they are used somewhere.

@mary-grace
Copy link
Contributor

@garrett thoughts on whether it's better to add the styles/icons as you've done, or simply remove the links in the CSS?

@pmkovar
Copy link
Member

pmkovar commented Feb 22, 2018

My take on this is that I'd rather live with a few 404's than adding unnecessary clutter but YMMV.

@rbowen rbowen merged commit b54ec45 into redhat-openstack:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants