Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic update :: puppet-ceilometer support for configuring coordination/backend_url #159

Closed
wants to merge 12 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Puppetfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ mod 'apache',
:git => 'https://github.com/puppetlabs/puppetlabs-apache.git'

mod 'ceilometer',
:commit => '1d78470e5023e2ca6adef47c904d14d046dd87d1',
:commit => 'ee2f3cd4498b2ef3a6633991206b7185c1d32897',
:git => 'https://github.com/stackforge/puppet-ceilometer.git'

mod 'certmonger',
:commit => '3f86b9973fc30c14a066b0f215023d5f1398b874',
:git => 'https://github.com/rcritten/puppet-certmonger.git'

mod 'cinder',
:commit => 'b5dce39754ed6857d6dc87b3ae29ed38057a487e',
:commit => '1ee8a6cab39da6beebf7a0b39207f0002368196f',
:git => 'https://github.com/stackforge/puppet-cinder.git'

mod 'common',
Expand All @@ -31,7 +31,7 @@ mod 'galera',
:git => 'https://github.com/rohara/puppet-galera.git'

mod 'glance',
:commit => '916a90ebdc3e9fafe956b12dcaa0e0ce3e7e3f04',
:commit => 'a243f89a52f7dd2dc16b36d1c9b79ec1616c6596',
:git => 'https://github.com/stackforge/puppet-glance.git'

mod 'gluster',
Expand All @@ -43,11 +43,11 @@ mod 'haproxy',
:git => 'https://github.com/puppetlabs/puppetlabs-haproxy.git'

mod 'heat',
:commit => '45a35dc2ec5f01bd79189ada881d083e1a51413b',
:commit => 'b1e9e9bd48c3da15be69c0797fb05e7ce0f6698f',
:git => 'https://github.com/stackforge/puppet-heat.git'

mod 'horizon',
:commit => '351c711004ccd9815e9a0d153bc5452461f7852d',
:commit => '353c372d582167d5635b1b2ee9474cf6822db032',
:git => 'https://github.com/stackforge/puppet-horizon.git'

mod 'inifile',
Expand Down Expand Up @@ -87,11 +87,11 @@ mod 'nagios',
:git => 'https://github.com/gildub/puppet-nagios-openstack.git'

mod 'neutron',
:commit => '663b4b16d22f78dbbb89c58170690a3c0a1e0ff2',
:commit => '67abde86d53969329bce37725627c2c661e49765',
:git => 'https://github.com/stackforge/puppet-neutron.git'

mod 'nova',
:commit => '261ae911fc5c325f6dd739a9b05f508a80a25034',
:commit => '181991927131206d4ea59a679e8108e36dc86c77',
:git => 'https://github.com/stackforge/puppet-nova.git'

mod 'nssdb',
Expand All @@ -107,7 +107,7 @@ mod 'openstack',
:git => 'https://github.com/stackforge/puppet-openstack.git'

mod 'openstacklib',
:commit => '2fc2e5504de7c298263a1d63af92974a7779d5c9',
:commit => 'e64e9c2a44833b25b602138b53a3187db49eaef8',
:git => 'https://github.com/stackforge/puppet-openstacklib.git'

mod 'pacemaker',
Expand Down Expand Up @@ -151,7 +151,7 @@ mod 'stdlib',
:git => 'https://github.com/puppetlabs/puppetlabs-stdlib.git'

mod 'swift',
:commit => '2193831dd787e9b24382c588dfa49917bcf47262',
:commit => '68a9e8eecba4a280ea1ec18fba67069a8c7dfce4',
:git => 'https://github.com/stackforge/puppet-swift.git'

mod 'sysctl',
Expand Down
35 changes: 33 additions & 2 deletions ceilometer/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Ceilometer
==========

4.0.0 - 2014.1.0 - Icehouse
5.0.0 - 2014.2.0 - Juno

#### Table of Contents

Expand Down Expand Up @@ -72,6 +72,37 @@ This is the ceilometer module.
Release Notes
-------------

** 5.0.0 **
* Stable Juno release
* Added package_ensure parameters to various classes to control package installation
* Added ceilometer::policy to control policy.json
* Updated validate_re expressions for Puppet 3.7
* Bumped stdlib dependency to >=4.0.0
* Added manage_service parameters to various classes to control whether the service was managed, as well as added enabled parameters where not already present
* Added parameters to control whether to configure keystone users
* Added the ability to override the keystone service name in ceilometer::keystone::auth
* Migrated the ceilometer::db::mysql class to use openstacklib::db::mysql and deprecated the mysql_module parameter
* Fixed ceilometer-notification package name for RHEL
* Removed deprecation notices for sectionless ceilometer_config types for Juno release
* Added ability to hide secrets from puppet logs

** 4.2.0 **

* Fixed dependency on nova-common package
* Added new class for extended logging options
* Fixed ssl parameter requirements for kombu and rabbit
* Fixed mysql_grant call
* Fixed ceilometer-collecter service relationships when service is disabled


** 4.1.0 **

* Added RabbitMQ SSL Support.
* Fixed dependency cycle bug.
* Fixed agent_notification_service_name.
* Changed default mysql charset to UTF8.
* Pinned major gems.

** 4.0.0 **

* Stable Icehouse release.
Expand All @@ -80,7 +111,6 @@ Release Notes
* Fixed region name configuration.
* Fixed ensure packages bug.
* Added support for puppetlabs-mysql 2.2 and greater.
* Fixed MySQL grant call.
* Introduced ceilometer::config to handle additional custom options.

** 3.1.1 **
Expand Down Expand Up @@ -126,3 +156,4 @@ Contact
-------

[email protected]
Ceilometer
9 changes: 9 additions & 0 deletions ceilometer/manifests/agent/central.pp
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,16 @@
# (optional) ensure state for package.
# Defaults to 'present'
#
# [*coordination_url*]
# (optional) The url to use for distributed group membership coordination.
# Defaults to undef.
#

class ceilometer::agent::central (
$manage_service = true,
$enabled = true,
$package_ensure = 'present',
$coordination_url = undef,
) {

include ceilometer::params
Expand Down Expand Up @@ -47,4 +52,8 @@
hasrestart => true,
}

if $coordination_url {
ensure_resource('ceilometer_config', 'coordination/backend_url',
{'value' => $coordination_url})
}
}
12 changes: 11 additions & 1 deletion ceilometer/manifests/alarm/evaluator.pp
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,18 @@
# (optional) Record alarm change events
# Defaults to true.
#
# [*coordination_url*]
# (optional) The url to use for distributed group membership coordination.
# Defaults to undef.
#
class ceilometer::alarm::evaluator (
$manage_service = true,
$enabled = true,
$evaluation_interval = 60,
$evaluation_service = 'ceilometer.alarm.service.SingletonAlarmService',
$partition_rpc_topic = 'alarm_partition_coordination',
$record_history = true,
$coordination_url = undef,
) {

include ceilometer::params
Expand Down Expand Up @@ -67,5 +72,10 @@
'alarm/evaluation_service' : value => $evaluation_service;
'alarm/partition_rpc_topic' : value => $partition_rpc_topic;
'alarm/record_history' : value => $record_history;
}
}

if $coordination_url {
ensure_resource('ceilometer_config', 'coordination/backend_url',
{'value' => $coordination_url})
}
}
12 changes: 9 additions & 3 deletions ceilometer/spec/classes/ceilometer_agent_central_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@
end

let :params do
{ :enabled => true,
:manage_service => true,
:package_ensure => 'latest' }
{ :enabled => true,
:manage_service => true,
:package_ensure => 'latest',
:coordination_url => 'redis://localhost:6379'
}
end

shared_examples_for 'ceilometer-agent-central' do
Expand Down Expand Up @@ -48,6 +50,10 @@
end
end

it 'configures central agent' do
should contain_ceilometer_config('coordination/backend_url').with_value( params[:coordination_url] )
end

context 'with disabled service managing' do
before do
params.merge!({
Expand Down
5 changes: 4 additions & 1 deletion ceilometer/spec/classes/ceilometer_alarm_evaluator_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,22 @@
should contain_ceilometer_config('alarm/evaluation_service').with_value( params[:evaluation_service] )
should contain_ceilometer_config('alarm/partition_rpc_topic').with_value( params[:partition_rpc_topic] )
should contain_ceilometer_config('alarm/record_history').with_value( params[:record_history] )
should_not contain_ceilometer_config('coordination/backend_url')
end

context 'when overriding parameters' do
before do
params.merge!(:evaluation_interval => 80,
:partition_rpc_topic => 'alarm_partition_coordination',
:record_history => false,
:evaluation_service => 'ceilometer.alarm.service.SingletonTestAlarmService')
:evaluation_service => 'ceilometer.alarm.service.SingletonTestAlarmService',
:coordination_url => 'redis://localhost:6379')
end
it { should contain_ceilometer_config('alarm/evaluation_interval').with_value(params[:evaluation_interval]) }
it { should contain_ceilometer_config('alarm/evaluation_service').with_value(params[:evaluation_service]) }
it { should contain_ceilometer_config('alarm/record_history').with_value(params[:record_history]) }
it { should contain_ceilometer_config('alarm/partition_rpc_topic').with_value(params[:partition_rpc_topic]) }
it { should contain_ceilometer_config('coordination/backend_url').with_value( params[:coordination_url]) }
end

context 'when override the evaluation interval with a non numeric value' do
Expand Down
37 changes: 36 additions & 1 deletion cinder/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
cinder
=======

4.0.0 - 2014.1.0 - Icehouse
5.0.0 - 2014.2.0 - Juno

#### Table of Contents

Expand Down Expand Up @@ -178,6 +178,41 @@ Contributors
Release Notes
-------------

**5.0.0**

* Stable Juno release
* Added class to manage policy.json
* Changed the default value of the san_thin_provision parameter for eqlx
* Added database tuning parameters
* Made keystone user creation optional when creating a service
* Added ability to hide secrets from logs
* Added parameters for netapp and and cinder-api workers
* Corrected the package name for cinder backup
* Added support for the EMC VNX direct driver
* Migrated the mysql backend to use openstacklib::db::mysql
* Added support for availability zones

**4.2.0**

* Added parameters to set cinder volume driver
* Added class for extended logging options
* Added option to specify endpoint protocol
* Fixed cinder type path issues
* Added option to specify cinder volume path
* Fixed targetcli package dependency on target service
* Fixed os version fact comparison for RedHat-based operating systems
for specifying service provider
* Added option to configure os_region_name in the cinder config

**4.1.0**

* Added Cinder v2 endpoint support.
* Added SSL support for Cinder API.
* Added RabbitMQ SSL support.
* Moved default_volume_type to cinder::api
* Removed warnings for existing Cinder volumes.
* Pinned major gems.

**4.0.0**

* Stable Icehouse release.
Expand Down
34 changes: 33 additions & 1 deletion glance/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
glance
=======

4.0.0 - 2014.1.0 - Icehouse
5.0.0 - 2014.2.0 - Juno

#### Table of Contents

Expand Down Expand Up @@ -133,6 +133,38 @@ Contributors
Release Notes
-------------

**5.0.0**

* Stable Juno release
* Added ceilometer::policy to control policy.json
* Fixed bug in glance_image type
* Added parameter os_region_name to glance::api
* Added support for vSphere datastore backend
* Updated the calls to the glance command-line utility
* Added parameter swift_store_large_object_size to glance::backend::swift
* Bumped stdlib dependency to >=4.0.0
* Added parameter command_options to glance::cache::cleaner and glance::cache::pruner
* Added parameter package_ensure to glance::backend::rbd
* Added parameter manage_service to various classes
* Added parameters to control whether to configure users
* Migrated the glance::db::mysql class to use openstacklib::db::mysql and deprecated the mysql_module parameter
* Added parameter registery_client_protocol to glance::api
* Fixed ssl parameter requirements for kombu and rabbit

**4.2.0**

* Added ability to hide secret type parameters from logs

**4.1.0**

* Added multiple rabbit hosts support.
* Added image_cache_dir parameter.
* Deprecated old SQL parameters.
* Fixed the Glance add_image parser for new client.
* Fixed values in get_glance_image_attrs.
* Fixed 'could not find user glance' bug.
* Pinned major gems.

**4.0.0**

* Stable Icehouse release.
Expand Down
4 changes: 2 additions & 2 deletions glance/manifests/api.pp
Original file line number Diff line number Diff line change
Expand Up @@ -290,11 +290,11 @@
# known_stores config
if $known_stores {
glance_api_config {
'DEFAULT/known_stores': value => join($known_stores, ',');
'glance_store/stores': value => join($known_stores, ',');
}
} else {
glance_api_config {
'DEFAULT/known_stores': ensure => absent;
'glance_store/stores': ensure => absent;
}
}

Expand Down
2 changes: 1 addition & 1 deletion glance/manifests/backend/cinder.pp
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
'DEFAULT/cinder_api_insecure': value => $cinder_api_insecure;
'DEFAULT/cinder_catalog_info': value => $cinder_catalog_info;
'DEFAULT/cinder_http_retries': value => $cinder_http_retries;
'DEFAULT/default_store': value => 'cinder';
'glance_store/default_store': value => 'cinder';
}

glance_cache_config {
Expand Down
6 changes: 3 additions & 3 deletions glance/manifests/backend/file.pp
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
) inherits glance::api {

glance_api_config {
'DEFAULT/default_store': value => 'file';
'DEFAULT/filesystem_store_datadir': value => $filesystem_store_datadir;
'glance_store/default_store': value => 'file';
'glance_store/filesystem_store_datadir': value => $filesystem_store_datadir;
}

glance_cache_config {
'DEFAULT/filesystem_store_datadir': value => $filesystem_store_datadir;
'glance_store/filesystem_store_datadir': value => $filesystem_store_datadir;
}
}
2 changes: 1 addition & 1 deletion glance/manifests/backend/rbd.pp
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
}

glance_api_config {
'DEFAULT/default_store': value => 'rbd';
'DEFAULT/rbd_store_ceph_conf': value => $rbd_store_ceph_conf;
'DEFAULT/rbd_store_user': value => $rbd_store_user;
'DEFAULT/rbd_store_pool': value => $rbd_store_pool;
'DEFAULT/rbd_store_chunk_size': value => $rbd_store_chunk_size;
'glance_store/default_store': value => 'rbd';
}

package { 'python-ceph':
Expand Down
Loading