Update cinder to 59f9e2c07f2a2fe981322e77b12d4862fe599a57

59f9e2c07f2a2fe981322e77b12d4862fe599a57 Merge "Cinder should use lioadm on Fedora"
8234d4471898339388d8550cacacb5dbaede1acd Merge "Support the enable_v*_api settings"
39b28be81733f2dfe899df63739dec6a2dc98cb9 Cinder should use lioadm on Fedora
709a2b7e3ed490747efbd7df4417ed05a8e34edd Support the enable_v*_api settings
6c47d9f4bc09a24e8ed7f2e5a1f906e047c143b0 Add Puppet 4.x lint checks

Puppetfile

@@ -15,7 +15,7 @@ mod 'certmonger',
   :git => 'https://github.com/rcritten/puppet-certmonger.git'
 
 mod 'cinder',
-  :commit => '8cc6d0e60ee6d9d0c1ebcf3523b07c3024c47064',
+  :commit => '59f9e2c07f2a2fe981322e77b12d4862fe599a57',
   :git => 'https://github.com/stackforge/puppet-cinder.git'
 
 mod 'common',

cinder/Gemfile

@@ -2,9 +2,19 @@ source 'https://rubygems.org'
 
 group :development, :test do
   gem 'puppetlabs_spec_helper', :require => false
+
   gem 'puppet-lint', '~> 1.1'
-  gem 'rspec-puppet', '~> 1.0.1'
   gem 'puppet-lint-param-docs', '1.1.0'
+  gem 'puppet-lint-absolute_classname-check'
+  gem 'puppet-lint-absolute_template_path'
+  gem 'puppet-lint-trailing_newline-check'
+  # Puppet 4.x related lint checks
+  gem 'puppet-lint-unquoted_string-check'
+  gem 'puppet-lint-leading_zero-check'
+  gem 'puppet-lint-variable_contains_upcase'
+  gem 'puppet-lint-numericvariable'
+
+  gem 'rspec-puppet', '~> 1.0.1'
   gem 'rake', '10.1.1'
   gem 'rspec', '< 2.99'
   gem 'json'

cinder/examples/cinder_volume_with_pacemaker.pp

@@ -21,18 +21,18 @@
 #
 # sudo pcs constraint colocation add cinder_api_service with cinder_vip
 
-class { 'cinder':
+class { '::cinder':
   database_connection  => 'mysql://cinder:[email protected]/cinder',
 }
 
-class { 'cinder::api':
+class { '::cinder::api':
   keystone_password => 'CINDER_PW',
   keystone_user     => 'cinder',
   enabled           => false,
   manage_service    => false,
 }
 
-class { 'cinder::scheduler':
+class { '::cinder::scheduler':
   scheduler_driver => 'cinder.scheduler.simple.SimpleScheduler',
   enabled          => false,
   manage_service   => false,

cinder/manifests/api.pp

@@ -132,8 +132,8 @@
   $validation_options         = {},
 ) {
 
-  include cinder::params
-  include cinder::policy
+  include ::cinder::params
+  include ::cinder::policy
 
   Cinder_config<||> ~> Service['cinder-api']
   Cinder_api_paste_ini<||> ~> Service['cinder-api']

cinder/manifests/backend/emc_vnx.pp

@@ -47,7 +47,7 @@
   $volume_backend_name        = $name,
 ) {
 
-  include cinder::params
+  include ::cinder::params
 
   cinder_config {
     "${name}/default_timeout":            value => $default_timeout;

cinder/manifests/backend/iscsi.pp

@@ -15,7 +15,7 @@
   $iscsi_helper        = $::cinder::params::iscsi_helper,
 ) {
 
-  include cinder::params
+  include ::cinder::params
 
   cinder_config {
     "${name}/volume_backend_name":  value => $volume_backend_name;

cinder/manifests/backend/rbd.pp

@@ -49,7 +49,7 @@
   $rbd_max_clone_depth              = '5',
 ) {
 
-  include cinder::params
+  include ::cinder::params
 
   cinder_config {
     "${name}/volume_backend_name":              value => $volume_backend_name;

cinder/manifests/backup.pp

@@ -58,7 +58,7 @@
   $backup_name_template = 'backup-%s'
 ) {
 
-  include cinder::params
+  include ::cinder::params
 
   Cinder_config<||> ~> Service['cinder-backup']
   Exec<| title == 'cinder-manage db_sync' |> ~> Service['cinder-backup']

cinder/manifests/client.pp

@@ -12,7 +12,7 @@
   $package_ensure = 'present'
 ) {
 
-  include cinder::params
+  include ::cinder::params
 
   package { 'python-cinderclient':
     ensure => $package_ensure,

cinder/manifests/db/sync.pp

@@ -1,7 +1,7 @@
 #
 class cinder::db::sync {
 
-  include cinder::params
+  include ::cinder::params
 
   exec { 'cinder-manage db_sync':
     command     => $::cinder::params::db_sync_command,

cinder/manifests/init.pp

@@ -196,6 +196,15 @@
 #   (Optional)
 #   Defaults to '/etc/cinder/api-paste.ini',
 #
+# [*enable_v1_api*]
+#   (Optional) Whether to enable the v1 API (true/false).
+#   This will be deprecated in Kilo.
+#   Defaults to 'true'.
+#
+# [*enable_v2_api*]
+#   (Optional) Whether to enable the v1 API (true/false).
+#   Defaults to 'true'.
+#
 # === Deprecated Parameters
 #
 # [*mysql_module*]
@@ -250,11 +259,13 @@
   $debug                       = false,
   $storage_availability_zone   = 'nova',
   $default_availability_zone   = false,
+  $enable_v1_api               = true,
+  $enable_v2_api               = true,
   # DEPRECATED PARAMETERS
   $mysql_module                = undef,
 ) {
 
-  include cinder::params
+  include ::cinder::params
 
   Package['cinder'] -> Cinder_config<||>
   Package['cinder'] -> Cinder_api_paste_ini<||>
@@ -489,4 +500,10 @@
     }
   }
 
+  # V1/V2 APIs
+  cinder_config {
+    'DEFAULT/enable_v1_api':        value => $enable_v1_api;
+    'DEFAULT/enable_v2_api':        value => $enable_v2_api;
+  }
+
 }

cinder/manifests/params.pp

@@ -50,7 +50,7 @@
         }
       }
       default: {
-        $iscsi_helper = 'tgtadm'
+        $iscsi_helper = 'lioadm'
       }
     }
 

cinder/manifests/qpid.pp

@@ -51,7 +51,7 @@
     $service_ensure = 'stopped'
   }
 
-  class { 'qpid::server':
+  class { '::qpid::server':
     service_ensure => $service_ensure
   }
 

cinder/manifests/scheduler.pp

@@ -28,7 +28,7 @@
   $manage_service   = true
 ) {
 
-  include cinder::params
+  include ::cinder::params
 
   Cinder_config<||> ~> Service['cinder-scheduler']
   Cinder_api_paste_ini<||> ~> Service['cinder-scheduler']

cinder/manifests/type_set.pp

@@ -58,7 +58,7 @@
   exec {"cinder type-key ${type} set ${key}=${name}":
     path        => ['/usr/bin', '/bin'],
     command     => "cinder type-key ${type} set ${key}=${name}",
-    unless      => "cinder extra-specs-list | grep -Eq '\b${type}\b.*\b${key}\b.*\b${name}\b'",
+    unless      => "cinder extra-specs-list | grep -Eq '\\b${type}\\b.*\\b${key}\\b.*\\b${name}\\b'",
     environment => concat($cinder_env, $region_env),
     require     => Package['python-cinderclient']
   }

cinder/manifests/volume.pp

@@ -20,7 +20,7 @@
   $manage_service = true
 ) {
 
-  include cinder::params
+  include ::cinder::params
 
   Cinder_config<||> ~> Service['cinder-volume']
   Cinder_api_paste_ini<||> ~> Service['cinder-volume']

cinder/manifests/volume/iscsi.pp

@@ -26,7 +26,7 @@
   $iscsi_helper      = $::cinder::params::iscsi_helper,
 ) {
 
-  include cinder::params
+  include ::cinder::params
 
   cinder::backend::iscsi { 'DEFAULT':
     iscsi_ip_address => $iscsi_ip_address,

cinder/spec/classes/cinder_spec.rb

@@ -379,4 +379,17 @@
     end
   end
 
+  describe 'with APIs set for Kilo (proposed)' do
+    let :params do
+      {
+        :enable_v1_api   => false,
+        :enable_v2_api   => true,
+        :rabbit_password => 'guest',
+      }
+    end
+
+    it { should contain_cinder_config('DEFAULT/enable_v1_api').with_value(false) }
+    it { should contain_cinder_config('DEFAULT/enable_v2_api').with_value(true) }
+
+  end
 end

cinder/spec/classes/cinder_volume_iscsi_spec.rb

@@ -49,7 +49,9 @@
     end
 
     let :facts do
-      {:osfamily => 'RedHat'}
+      {:osfamily => 'RedHat',
+       :operatingsystem => 'RedHat',
+       :operatingsystemmajrelease => '6'}
     end
 
     it { should contain_file_line('cinder include').with(