Merge pull request #51 from jburnham/feature/pidfile-support

Add support for custom and disabling of pidfiles.

README.md

@@ -33,6 +33,7 @@ If you find this module useful, send some bitcoins to 1Na3YFUmdxKxJLiuRXQYJU2kiN
 
 * $package_ensure = 'present'
 * $logfile = '/var/log/memcached.log'
+* $pidfile = '/var/run/memcached.pid' (Debian family only, set to false to disable pidfile)
 * $max_memory = false
 * $item_size = false
 * $lock_memory = false (WARNING: good if used intelligently, google for -k key)

manifests/init.pp

@@ -5,6 +5,7 @@
 class memcached (
   $package_ensure  = 'present',
   $logfile         = '/var/log/memcached.log',
+  $pidfile         = '/var/run/memcached.pid',
   $manage_firewall = false,
   $max_memory      = false,
   $item_size       = false,

spec/classes/memcached_spec.rb

@@ -96,6 +96,12 @@
       :install_dev     => true,
       :processorcount  => 1
     },
+    {
+      :pidfile         => false,
+    },
+    {
+      :pidfile         => '/var/log/memcached.pid',
+    },
     {
       :package_ensure  => 'absent',
       :install_dev     => true
@@ -185,6 +191,9 @@
             if(param_hash[:lock_memory])
               expected_lines.push("-k")
             end
+            if(param_hash[:pidfile])
+              expected_lines.push("-P #{param_hash[:pidfile]}")
+            end
             if(param_hash[:verbosity])
               expected_lines.push("-vvv")
             end

templates/memcached.conf.erb

@@ -3,8 +3,10 @@
 # Run memcached as a daemon.
 -d
 
+<% if @pidfile -%>
 # pidfile
--P /var/run/memcached.pid
+-P <%= @pidfile %>
+<% end -%>
 
 # Log memcached's output
 logfile <%= @logfile -%>