Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator grafana-operator (5.6.2-hotfix1) #4002

Conversation

NissesSenap
Copy link
Contributor

Your submission should not

  • Add more than one operator bundle per PR
  • Modify any operator
  • Rename an operator
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description of the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@rh-operator-bundle-bot
Copy link
Contributor

Pipeline Summary

Pipeline: community-hosted-pipeline
PipelineRun: community-hosted-pipeline-run6tvpl
Start Time: 2024-02-08 08:54:09+00:00

Tasks

Status Task Start Time Duration
✔️ get-pr-number 2024-02-08 08:54:09+00:00 7 seconds
✔️ acquire-lease 2024-02-08 08:54:19+00:00 6 seconds
✔️ set-github-started-label 2024-02-08 08:54:26+00:00 9 seconds
✔️ set-github-status-pending 2024-02-08 08:54:35+00:00 7 seconds
✔️ set-env-community 2024-02-08 08:54:42+00:00 8 seconds
✔️ clone-repository 2024-02-08 08:54:51+00:00 32 seconds
✔️ clone-repository-base 2024-02-08 08:54:52+00:00 31 seconds
detect-changes 2024-02-08 08:55:25+00:00 55 seconds

Pipeline logs: https://gist.github.com/rh-operator-bundle-bot/f0cc2bb6a37bd43858de55d224f31645

Troubleshooting

Run /pipeline restart community-hosted-pipeline in case of pipeline failure to restart a pipeline.

@NissesSenap
Copy link
Contributor Author

Sorry for the ping, I don't know how else to solve this.
@mporrato @Allda @tomasbakk @haripate
I need to change 5.6.2 and skip 5.6.1, this due to a breaking change that we introduced in 5.6.1. And apparently the automated upgrades don't jump versions.

At least not according to: grafana/grafana-operator#1399
If we can override the template it would be great, if you have any other ideas on how to solve this please share.

@mporrato
Copy link
Collaborator

mporrato commented Feb 8, 2024

@NissesSenap this can't be merged for two reasons:

  1. the new pipeline does not allow changing existing bundles
  2. 5.6.1 would be left with no valid path to the latest bundle in the channel (5.6.2) and this would be detected by the ci and be rejected

If the upgrade issue has been fixed in 5.6.2, I would suggest releasing a new version that specifies

replaces: grafana-operator.v5.6.2
skips:
  - grafana-operator.v5.6.1

See https://olm.operatorframework.io/docs/concepts/olm-architecture/operator-catalog/creating-an-update-graph/ .

@NissesSenap
Copy link
Contributor Author

Thanks for your respons
@mporrato does OLM support fix versions?

Can I do something like 5.6.2.1 or 5.6.2.fix?

@NissesSenap NissesSenap force-pushed the update-grafana-operator-v5.6.2-fix branch from 53e66cb to 93056b2 Compare February 8, 2024 10:35
@rh-operator-bundle-bot rh-operator-bundle-bot changed the title operator grafana-operator (5.6.2) fix operator grafana-operator (5.6.2.1) Feb 8, 2024
Comment on lines 434 to 437
replaces: grafana-operator.v5.6.2
skips:
- grafana-operator.v5.6.1
version: 5.6.2.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice replaces and skip.
I also call the version 5.6.2.1

@rh-operator-bundle-bot
Copy link
Contributor

Pipeline Summary

Pipeline: community-hosted-pipeline
PipelineRun: community-hosted-pipeline-run959mz
Start Time: 2024-02-08 10:35:03+00:00

Tasks

Status Task Start Time Duration
✔️ get-pr-number 2024-02-08 10:35:03+00:00 6 seconds
✔️ acquire-lease 2024-02-08 10:35:13+00:00 8 seconds
✔️ set-github-started-label 2024-02-08 10:35:24+00:00 10 seconds
✔️ set-github-status-pending 2024-02-08 10:35:38+00:00 7 seconds
✔️ set-env-community 2024-02-08 10:35:46+00:00 6 seconds
✔️ clone-repository 2024-02-08 10:35:54+00:00 31 seconds
✔️ clone-repository-base 2024-02-08 10:35:55+00:00 31 seconds
✔️ detect-changes 2024-02-08 10:36:29+00:00 34 seconds
✔️ set-github-pr-title 2024-02-08 10:37:03+00:00 8 seconds
✔️ get-ci-reviewer 2024-02-08 10:37:13+00:00 34 seconds
✔️ read-config 2024-02-08 10:37:47+00:00 10 seconds
✔️ apply-test-waivers 2024-02-08 10:37:57+00:00 11 seconds
✔️ get-supported-versions 2024-02-08 10:38:08+00:00 12 seconds
static-tests 2024-02-08 10:38:21+00:00 38 seconds

Pipeline logs: https://gist.github.com/rh-operator-bundle-bot/7be9d013072dc6c991d17ba54b08827e

Troubleshooting

Run /pipeline restart community-hosted-pipeline in case of pipeline failure to restart a pipeline.

@mporrato
Copy link
Collaborator

mporrato commented Feb 8, 2024

@NissesSenap the version string must be a valid semver: x.y.z.j is not. You could use something like 5.6.2+hotfix1.

@rh-operator-bundle-bot rh-operator-bundle-bot changed the title operator grafana-operator (5.6.2.1) operator grafana-operator (5.6.2+hotfix1) Feb 8, 2024
@rh-operator-bundle-bot
Copy link
Contributor

Static test results

Status Check Message
check_upgrade_graph_loop Upgrade graph loop detected for bundle: [Bundle(grafana-operator/5.1.0), Bundle(grafana-operator/5.2.0), Bundle(grafana-operator/5.3.0), Bundle(grafana-operator/5.4.0), Bundle(grafana-operator/5.4.1), Bundle(grafana-operator/5.4.2), Bundle(grafana-operator/5.5.0), Bundle(grafana-operator/5.5.2), Bundle(grafana-operator/5.6.0), Bundle(grafana-operator/5.6.1), Bundle(grafana-operator/5.6.2), Bundle(grafana-operator/5.6.2+hotfix1)]

@rh-operator-bundle-bot
Copy link
Contributor

Pipeline Summary

Pipeline: community-hosted-pipeline
PipelineRun: community-hosted-pipeline-run689k5
Start Time: 2024-02-08 11:00:16+00:00

Tasks

Status Task Start Time Duration
✔️ get-pr-number 2024-02-08 11:00:17+00:00 7 seconds
✔️ acquire-lease 2024-02-08 11:00:26+00:00 7 seconds
✔️ set-github-started-label 2024-02-08 11:00:34+00:00 10 seconds
✔️ set-github-status-pending 2024-02-08 11:00:44+00:00 8 seconds
✔️ set-env-community 2024-02-08 11:00:53+00:00 8 seconds
✔️ clone-repository-base 2024-02-08 11:01:02+00:00 25 seconds
✔️ clone-repository 2024-02-08 11:01:02+00:00 26 seconds
✔️ detect-changes 2024-02-08 11:01:29+00:00 36 seconds
✔️ set-github-pr-title 2024-02-08 11:02:06+00:00 9 seconds
✔️ get-ci-reviewer 2024-02-08 11:02:15+00:00 35 seconds
✔️ read-config 2024-02-08 11:02:51+00:00 10 seconds
✔️ apply-test-waivers 2024-02-08 11:03:01+00:00 11 seconds
✔️ get-supported-versions 2024-02-08 11:03:12+00:00 12 seconds
✔️ static-tests 2024-02-08 11:03:24+00:00 38 seconds
static-tests-results 2024-02-08 11:04:02+00:00 25 seconds

Pipeline logs: https://gist.github.com/rh-operator-bundle-bot/9015021a48a6b10202fcee9c572dc681

Troubleshooting

Run /pipeline restart community-hosted-pipeline in case of pipeline failure to restart a pipeline.

@rh-operator-bundle-bot
Copy link
Contributor

Static test results

Status Check Message
check_dangling_bundles Channel v5 has dangling bundles: {Bundle(grafana-operator/5.6.2+hotfix1)}

@rh-operator-bundle-bot
Copy link
Contributor

Pipeline Summary

Pipeline: community-hosted-pipeline
PipelineRun: community-hosted-pipeline-run9bptc
Start Time: 2024-02-08 12:27:08+00:00

Tasks

Status Task Start Time Duration
✔️ get-pr-number 2024-02-08 12:27:09+00:00 5 seconds
✔️ acquire-lease 2024-02-08 12:27:17+00:00 5 seconds
✔️ set-github-started-label 2024-02-08 12:27:24+00:00 10 seconds
✔️ set-github-status-pending 2024-02-08 12:27:34+00:00 9 seconds
✔️ set-env-community 2024-02-08 12:27:43+00:00 7 seconds
✔️ clone-repository-base 2024-02-08 12:27:51+00:00 31 seconds
✔️ clone-repository 2024-02-08 12:27:52+00:00 30 seconds
✔️ detect-changes 2024-02-08 12:28:23+00:00 48 seconds
✔️ set-github-pr-title 2024-02-08 12:29:12+00:00 7 seconds
✔️ get-ci-reviewer 2024-02-08 12:29:19+00:00 30 seconds
✔️ read-config 2024-02-08 12:29:49+00:00 47 seconds
✔️ apply-test-waivers 2024-02-08 12:30:36+00:00 48 seconds
✔️ get-supported-versions 2024-02-08 12:31:24+00:00 45 seconds
✔️ static-tests 2024-02-08 12:32:09+00:00 a minute
static-tests-results 2024-02-08 12:33:18+00:00 33 seconds

Pipeline logs: https://gist.github.com/rh-operator-bundle-bot/64b73a2271b030dd2bdda0d580e64964

Troubleshooting

Run /pipeline restart community-hosted-pipeline in case of pipeline failure to restart a pipeline.

@NissesSenap
Copy link
Contributor Author

My guess #4002 (comment) means that I need to rename the folder. Lets see if I'm right

@rh-operator-bundle-bot rh-operator-bundle-bot changed the title operator grafana-operator (5.6.2+hotfix1) operator grafana-operator (5.6.2-hotfix1) Feb 8, 2024
@rh-operator-bundle-bot
Copy link
Contributor

Pipeline Summary

Pipeline: community-hosted-pipeline
PipelineRun: community-hosted-pipeline-runm6ctj
Start Time: 2024-02-08 12:34:59+00:00

Tasks

Status Task Start Time Duration
✔️ get-pr-number 2024-02-08 12:35:00+00:00 6 seconds
✔️ acquire-lease 2024-02-08 12:35:08+00:00 7 seconds
✔️ set-github-started-label 2024-02-08 12:35:16+00:00 9 seconds
✔️ set-github-status-pending 2024-02-08 12:35:26+00:00 8 seconds
✔️ set-env-community 2024-02-08 12:35:35+00:00 7 seconds
✔️ clone-repository 2024-02-08 12:35:43+00:00 32 seconds
✔️ clone-repository-base 2024-02-08 12:35:43+00:00 32 seconds
✔️ detect-changes 2024-02-08 12:36:15+00:00 11 seconds
✔️ set-github-pr-title 2024-02-08 12:36:26+00:00 7 seconds
✔️ get-ci-reviewer 2024-02-08 12:36:35+00:00 32 seconds
✔️ read-config 2024-02-08 12:37:07+00:00 12 seconds
✔️ apply-test-waivers 2024-02-08 12:37:19+00:00 11 seconds
✔️ get-supported-versions 2024-02-08 12:37:30+00:00 12 seconds
static-tests 2024-02-08 12:37:43+00:00 a minute

Pipeline logs: https://gist.github.com/rh-operator-bundle-bot/6c4b1aef298cd071b23ebda8faca12de

Troubleshooting

Run /pipeline restart community-hosted-pipeline in case of pipeline failure to restart a pipeline.

@mporrato
Copy link
Collaborator

mporrato commented Feb 8, 2024

@NissesSenap yes, it looks like we can't use the + character in container tag. 5.6.2-hotfix1 should work. Also make sure to align the directory name with the version and the name in the csv.
Sorry for the inconvenience, but this is not a use case we have tested before.

@rh-operator-bundle-bot
Copy link
Contributor

Static test results

Status Check Message
check_dangling_bundles Channel v5 has dangling bundles: {Bundle(grafana-operator/5.6.2-hotfix1)}

@rh-operator-bundle-bot
Copy link
Contributor

Pipeline Summary

Pipeline: community-hosted-pipeline
PipelineRun: community-hosted-pipeline-runj56px
Start Time: 2024-02-08 14:07:08+00:00

Tasks

Status Task Start Time Duration
✔️ get-pr-number 2024-02-08 14:07:08+00:00 8 seconds
✔️ acquire-lease 2024-02-08 14:07:18+00:00 7 seconds
✔️ set-github-started-label 2024-02-08 14:07:26+00:00 11 seconds
✔️ set-github-status-pending 2024-02-08 14:07:37+00:00 8 seconds
✔️ set-env-community 2024-02-08 14:07:45+00:00 7 seconds
✔️ clone-repository 2024-02-08 14:07:54+00:00 43 seconds
✔️ clone-repository-base 2024-02-08 14:07:55+00:00 43 seconds
✔️ detect-changes 2024-02-08 14:08:40+00:00 35 seconds
✔️ set-github-pr-title 2024-02-08 14:09:16+00:00 8 seconds
✔️ get-ci-reviewer 2024-02-08 14:09:24+00:00 33 seconds
✔️ read-config 2024-02-08 14:09:57+00:00 10 seconds
✔️ apply-test-waivers 2024-02-08 14:10:08+00:00 11 seconds
✔️ get-supported-versions 2024-02-08 14:10:19+00:00 11 seconds
✔️ static-tests 2024-02-08 14:10:30+00:00 39 seconds
static-tests-results 2024-02-08 14:11:10+00:00 11 seconds

Pipeline logs: https://gist.github.com/rh-operator-bundle-bot/5dcbe8c67fa482dbd3b72ca4471d4907

Troubleshooting

Run /pipeline restart community-hosted-pipeline in case of pipeline failure to restart a pipeline.

@NissesSenap
Copy link
Contributor Author

Hmm says https://gist.github.com/rh-operator-bundle-bot/5dcbe8c67fa482dbd3b72ca4471d4907 still dangling bundles

[static-tests : run-suite] {
[static-tests : run-suite]   "passed": false,
[static-tests : run-suite]   "outputs": [
[static-tests : run-suite]     {
[static-tests : run-suite]       "type": "error",
[static-tests : run-suite]       "message": "Channel v5 has dangling bundles: {Bundle(grafana-operator/5.6.2-hotfix1)}",
[static-tests : run-suite]       "check": "check_dangling_bundles"
[static-tests : run-suite]     }
[static-tests : run-suite]   ]

So I guess there are some configs around this, that it still don't like.
Unless you have some other idea, I guess we will cut a new release instead and skip all this.

Thanks for your help @mporrato

@NissesSenap
Copy link
Contributor Author

I have cut a new release instead: #4017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants