fix: ubi9 #53
Merged
fix: ubi9 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangchen2019
approved these changes
Sep 4, 2024
mxpaspa
approved these changes
Sep 5, 2024
jiangchen2019
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UBI9, openssl v3, the GetSymbolPointer for
FIPS_modein fips-detect is no longer correct and leads to an error.https://github.com/acardace/fips-detect/blob/main/pkg/fips/fips.go#L115
It may be that a Get for EVP_default_properties_is_fips_enabled would be a correct substitution
https://github.com/dacleyra/fips-detect/blob/main/pkg/fips/fips.go#L115
https://docs.openssl.org/3.0/man3/
In any case, at this point we have confidence we are building with openssl fips with the ubi go-toolset, so the tool is not necessary.