Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup #13

Merged
merged 8 commits into from
Jan 25, 2023
Merged

cleanup #13

merged 8 commits into from
Jan 25, 2023

Conversation

dacleyra
Copy link
Contributor

@dacleyra dacleyra commented Jun 28, 2022 •
edited
Loading

Fix some of the outstanding comments in pull/11

  • Display error with information about unsupported source type
    • use switch and use api.Type instead of dupe string consts
  • change to upper case ILMT
  • Pulls files from RHM Operator's Dataservice or IBM Licence Metric Tool
  • Comments about auto-generate doc, it seems it should be consuming os.Getenv(HOME), but it's not

Can continue to use this branch/PR to address items in symposium 25448

  • Update README with dataservice sources steps

@dacleyra dacleyra requested review from MJSiddu, mxpaspa and ab-ibm June 28, 2022 19:41
@dacleyra dacleyra merged commit fd2fc05 into feature/multipleSources Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MJSiddu MJSiddu Awaiting requested review from MJSiddu

@mxpaspa mxpaspa Awaiting requested review from mxpaspa

@ab-ibm ab-ibm Awaiting requested review from ab-ibm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dacleyra @mxpaspa @ab-ibm