Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support generate snippets for object and array according to schema #87

Merged
merged 2 commits into from
Sep 9, 2018

Conversation

928PJY
Copy link
Contributor

@928PJY 928PJY commented Sep 6, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 71.545% when pulling 87b4d62 on 928PJY:object into e422bde on redhat-developer:master.

@coveralls
Copy link

coveralls commented Sep 6, 2018

Coverage Status

Coverage increased (+1.4%) to 71.588% when pulling 0f62274 on 928PJY:object into e422bde on redhat-developer:master.

@JPinkney JPinkney self-requested a review September 6, 2018 13:16
@JPinkney
Copy link
Contributor

JPinkney commented Sep 6, 2018

One thing I've found is objects and arrays no longer self indent. For example, before i could do

meta

and have that autocomplete to

metadata:
  <- cursor is here

but now it just brings me to the start of the new line

metadata:
<-

@928PJY
Copy link
Contributor Author

928PJY commented Sep 7, 2018

can you give me a schema that I can repro this? it's not an expected behavior


In reply to: 419091296 [](ancestors = 419091296)

@JPinkney
Copy link
Contributor

JPinkney commented Sep 7, 2018

I was testing on the kubernetes schema (https://gist.githubusercontent.com/JPinkney/ccaf3909ef811e5657ca2e2e1fa05d76/raw/f85e51bfb67fdb99ab7653c2953b60087cc871ea/openshift_schema_all.json) or you can set it in the settings by doing:

"yaml.schemas": {
    "kubernetes": "*.yaml"
}

@928PJY
Copy link
Contributor Author

928PJY commented Sep 7, 2018

got it, this happens in the case that there is no required property or property with default value


In reply to: 419298080 [](ancestors = 419298080,419091296)

@928PJY
Copy link
Contributor Author

928PJY commented Sep 7, 2018

yeah! fixed. it is a bug
BTW, can we add test to test completion detail but not just completion item count.


In reply to: 419309025 [](ancestors = 419309025)

@JPinkney
Copy link
Contributor

JPinkney commented Sep 9, 2018

can we add test to test completion detail but not just completion item count

Yeah, thats something thats always been needed. I'm going to create an issue and will start converting the tests when I get a change.

Other then that it LGTM!

@JPinkney JPinkney merged commit b6f7282 into redhat-developer:master Sep 9, 2018
@928PJY 928PJY deleted the object branch September 9, 2018 02:51
@928PJY
Copy link
Contributor Author

928PJY commented Sep 12, 2018

Cool~
when would you publish a new version Npm package and extension?

@JPinkney
Copy link
Contributor

Should be published in a few hours, I just have to do a few other things first

@JPinkney
Copy link
Contributor

@928PJY Both have been released!

@928PJY
Copy link
Contributor Author

928PJY commented Sep 12, 2018

@JPinkney Cool! Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants