Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intellisense doesn't work for array item #85

Merged
merged 5 commits into from
Sep 6, 2018
Merged

intellisense doesn't work for array item #85

merged 5 commits into from
Sep 6, 2018

Conversation

928PJY
Copy link
Contributor

@928PJY 928PJY commented Aug 29, 2018

if there is no space between - and holder, the yaml structure will be wrong, so the array intellisense doesn't work

@coveralls
Copy link

coveralls commented Aug 29, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 70.185% when pulling 34a252a on 928PJY:intel into 90fc8c0 on redhat-developer:master.

@JPinkney JPinkney self-requested a review August 30, 2018 11:51
@928PJY
Copy link
Contributor Author

928PJY commented Sep 4, 2018

Some comments? @JPinkney

@928PJY
Copy link
Contributor Author

928PJY commented Sep 6, 2018

This PR has been inactive for 7 days, can you @JPinkney give some update?

@JPinkney
Copy link
Contributor

JPinkney commented Sep 6, 2018

I have been on vacation.

@JPinkney JPinkney merged commit e422bde into redhat-developer:master Sep 6, 2018
@928PJY
Copy link
Contributor Author

928PJY commented Sep 6, 2018

oh~ sorry for that

In reply to: 418946400 [](ancestors = 418946400)

@928PJY 928PJY deleted the intel branch September 6, 2018 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPinkney JPinkney JPinkney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@928PJY @coveralls @JPinkney