Add 'doDocumentOnTypeFormatting' implementation #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
…rver into add-on-type-formatting
|
This looks like a really cool feature. I usually never use formatOnType but in this case it seems really useful |
Signed-off-by: Yevhen Vydolob <[email protected]>
JPinkney
reviewed
Jan 18, 2021
…rver into add-on-type-formatting Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
JPinkney
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add implementation for doDocumentOnTypeFormatting feature.
It allows to format text as user typing. This implementation reacts on new line character and add proper indentation. Also it automatically add
-for array items if previous line contains list simple array item(not map or array).Demo:
Screen.Recording.2021-01-12.at.10.51.07.mov
What issues does this PR fix or reference?
redhat-developer/vscode-yaml#179
Is it tested? How?
If you want to test it manually you need to make sure that you enable
"editor.formatOnType"for yaml files, see first few second on demo.