Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain quotes for boolean values in defaultSnippets #234

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

JPinkney
Copy link
Contributor

@JPinkney JPinkney commented Feb 5, 2020

In a default snippet if the body has a quoted boolean value we want to maintain the quotes for that boolean value:

 {
     "label": "foo",
      "description": "Foo",
      "body": {
           "bar": "true"
      }
}

So when inserted it becomes bar: "true".

Likewise, if the boolean value is not quoted then we don't want to keep quotes.

So when inserted it would become bar: true

See: #225 (comment)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 77.247% when pulling 85a3131 on defaultSnippets-boolean-fix into be89eea on master.

@JPinkney JPinkney merged commit f09dabb into master Feb 10, 2020
@evidolob evidolob deleted the defaultSnippets-boolean-fix branch August 11, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants