-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for schema sequences #197
Conversation
Thanks @JPinkney - it's the weekend here but I'll take a look on Monday. Thanks heaps for the quick turnaround! |
I don't feel very qualified to comment on the code in detail, but it definitely looks like a solid approach and the implementation looks good. I'll install a local build and see if fixes the downstream problem with the k8s extension. Thanks! |
LGTM |
I'm not sure if I've got something wrong in the build chain ( |
I'm not sure how to track down the problem or help give any direction given how indirect the chain is - can't think of anything except sprinkling printfs and that doesn't seem very efficient... @JPinkney let me know if there's anything I can do to help validate whether there's a problem and if so to diagnose it. |
49c61d8
to
6dc9a60
Compare
Looking good now! I'm using @andxu's test pod/deployment YAML and the hints and errors are looking appropriate to me. Thanks! |
@itowlson I tested the new code and it works now |
@JPinkney Is there a timeframe for getting this into a release please? |
@itowlson I'll try for Friday, I'm a little short on time since I'm preparing for KubeCon |
Terrific - thanks @JPinkney! |
Fixes: #196
The idea of this PR is described in: #81 (comment)
cc @andxu @itowlson