Implement a way to determine if an extension is conflicting with VSCo…

[JPinkney]

Implement a way to determine if an extension is conflicting with VSCode-YAML

Signed-off-by: Josh Pinkney [email protected]

What does this PR do?

This PR makes it so that a notification will pop up prompting a user to uninstall conflicting extensions with VSCode-YAML

What issues does this PR fix or reference?

#404

Is it tested? How?

Launch extension with Ansible already installed -> you should see notification saying to uninstall -> click it and it should be uninstalled (though manual reload is required)

Launch extension without Ansible installed -> install Ansible -> you should see notification saying to uninstall -> click it and it should be uninstalled (though manual reload is required)

[joshuawilson]

@JPinkney I like the suggestion to just turn off validation in anisible here #404 (comment)

[JPinkney]

Yeah, I can change the code to be that. The only reason I had it like this originally is there are actually a few more conflicting extensions but I can't seem to find their VSCode ID's ATM. The other conflicting extensions are under 50k installs though so I'm not sure if it matters or not

[joshuawilson]

You could do both since you already have this. Set a generic check for a conflict and then the specific one for ansible that just turns off validation.

[JPinkney]

I went with just the ansible specific thing. It got a little awkward trying to determine what happened if VSCode Ansible and another extension were conflicting and what message I should show there etc

[joshuawilson]

Based on the comments in #404 (comment) I think we should go back to the generic version.

[evidolob]

LGTM

[joshuawilson]

Approved as is. Did you plan to look for those other extensions that conflict?

[JPinkney]

It took me a while but I finally found the conflicting extension that I was thinking of: https://marketplace.visualstudio.com/items?itemName=ms-vscode-deploy-azure.azure-deploy. If you install it along VSCode-YAML you get multiple YAML Support output channels and two YAML language servers are started when opening a yaml file.

Do you know if a deprecated extension still shows on the marketplace? Just wondering if we should switch back to generic and make it so that VSCode-Ansible/others will automatically uninstall (since VSCode-Ansible will be deprecated anyways) or if I should still have the ansible.validation: false for VSCode-Ansible users that are still using it and a generic solution for all other extensions. Any thoughts on which one I should do?

[joshuawilson]

I have not tried using a deprecated ext. I think generic is better but if you can't then just doing something simple for now is good enough. Though "automatically uninstalling" is not very nice. I think it is enough to tell them the cause.

[JPinkney]

Though "automatically uninstalling"

by automatic uninstalling I meant to say prompt them with a button asking if they want to uninstall (the way the PR was originally)

[gorkem]

ms-vscode-deploy-azure.azure-deploy seems to be active. Can you file an issue on its repo and ask them to switch to using the extension and not the yaml-language-server.

[JPinkney]

I filed one July 15 but I didn't get a response: microsoft/vscode-deploy-azure#130

[ssbarnea]

I am inclined to believe that haaaad.ansible and sysninja.vscode-ansible-mod should be added to the list.

[JPinkney]

I made some changes so that when an extension is conflicting it will only show in one information window. Previously when you installed Ansible, then installed vscode-deploy you'd get two popups. The first would say:

Remove ansible

and the second would say

Remove ansible and vscode-deploy