Allow multiple matches for one yaml file with requestCustomSchema #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorkem
reviewed
Jan 27, 2020
| * | ||
| * @param {string} resource | ||
| * @returns {string} the schema uri | ||
| */ | ||
| public requestCustomSchema(resource: string): string { | ||
| public requestCustomSchema(resource: string): string[] { |
There was a problem hiding this comment.
Similar to server should we keep compatibility by returning string or string[]?
There was a problem hiding this comment.
This part is just internal API, it needs to be string[] now so that it can find all matching schema contributes for the given file
bleach31
pushed a commit
to bleach31/vscode-yaml
that referenced
this pull request
Jan 25, 2022
…esWrongIndentation Fix required attributes insertion with first array item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a yaml file to be matched with multiple contributors.
This is then handled on the yaml language server side by redhat-developer/yaml-language-server#227