Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation does not work with kubernetes yaml #54

Closed
akaroml opened this issue Jan 16, 2018 · 2 comments
Closed

Validation does not work with kubernetes yaml #54

akaroml opened this issue Jan 16, 2018 · 2 comments

Comments

@akaroml
Copy link

akaroml commented Jan 16, 2018

Settings:

{
    "yaml.schemas": {
        "kubernetes": "pod.yaml"
    }
}

pod.yaml:

apiVersion: v1
kind: Pod
metadata:
  name: azure-vote-back
specs:
  containers:
  - name: azure-vote-back
    image: redis
    imagePullPolicy: Always
    ports:
    - containerPort: 6379
      name: redis

Result:
image

Expected result:
image

@JPinkney
Copy link
Contributor

I believe this is actually a schema issue from the schema generated via https://github.com/fabric8io/kubernetes-model. Because the "additionalProperties" field is always true in the schema [1] it interprets "specs" as additional and thus not validating.

[1] - http://central.maven.org/maven2/io/fabric8/kubernetes-model/2.0.0/kubernetes-model-2.0.0-schema.json

@JPinkney
Copy link
Contributor

With the updated kubernetes schema this has been resolved

apupier pushed a commit to apupier/vscode-yaml that referenced this issue Jul 2, 2020
bleach31 pushed a commit to bleach31/vscode-yaml that referenced this issue Jan 25, 2022
fix issue redhat-developer#37 completionHelper will break yaml file if it contains \r …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants