Added getting started page #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 67.92% // Head: 67.92% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
=======================================
Coverage 67.92% 67.92%
=======================================
Files 114 114
Lines 6619 6619
Branches 1157 1157
=======================================
Hits 4496 4496
Misses 2123 2123
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lstocchi
requested changes
Nov 15, 2022
mohitsuman
reviewed
Nov 17, 2022
mohitsuman
reviewed
Nov 17, 2022
package.json
Outdated
| { | ||
| "id": "Create Resources", | ||
| "title": "Create new resource", | ||
| "description": "The plugin allows creating a new Tekton resource directly from the YAML in the editor and deploying it using the Kubernetes: Create command available from the Kubernetes extension.", |
There was a problem hiding this comment.
Suggested change
| "description": "The plugin allows creating a new Tekton resource directly from the YAML in the editor and deploying it using the Kubernetes: Create command available from the Kubernetes extension.", | |
| "description": "Create a new Tekton resource directly from the YAML in the editor and deploy it using the `Kubernetes: Create` command.", |
mohitsuman
reviewed
Nov 17, 2022
mohitsuman
reviewed
Nov 19, 2022
package.json
Outdated
| "title": "Create new resource", | ||
| "description": "Create a new Tekton resource directly from the YAML in the editor and deploy it using the `Kubernetes: Create` command.", | ||
| "media": { | ||
| "image": "https://raw.githubusercontent.com/wiki/redhat-developer/vscode-tekton/images/walkthroughs/create-resource.gif", |
There was a problem hiding this comment.
Why are we using the raw location of the images? This should point to the local folder image.
Signed-off-by: Mohit Suman <[email protected]>
Signed-off-by: Mohit Suman <[email protected]>
Have fixed it in my commit with the images folder and description changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #691