Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow install Pipeline from TektonHub #645

Merged
merged 3 commits into from
Nov 18, 2021
Merged

Conversation

evidolob
Copy link
Collaborator

Resolve: #610

Demo:

Screen.Recording.2021-11-11.at.11.10.22.mov

@evidolob evidolob requested a review from sudhirverma November 11, 2021 09:12
@codecov-commenter
Copy link

Codecov Report

Merging #645 (6b45092) into master (fb9c474) will decrease coverage by 0.31%.
The diff coverage is 29.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
- Coverage   68.38%   68.06%   -0.32%     
==========================================
  Files         114      114              
  Lines        6538     6598      +60     
  Branches     1151     1161      +10     
==========================================
+ Hits         4471     4491      +20     
- Misses       2067     2107      +40     
Impacted Files Coverage Δ
src/hub/task-page-manager.ts 44.00% <0.00%> (ø)
src/tkn.ts 77.25% <ø> (ø)
src/hub/task-page-view.ts 19.46% <20.00%> (ø)
src/hub/hub-view.ts 25.36% <21.87%> (-0.45%) ⬇️
src/cli-command.ts 72.78% <33.33%> (-1.27%) ⬇️
src/hub/install-resource.ts 55.86% <33.92%> (ø)
src/hub/hub-client.ts 37.28% <42.85%> (-0.90%) ⬇️
src/hub/hub-common.ts 50.00% <50.00%> (ø)
src/extension.ts 79.70% <0.00%> (+1.98%) ⬆️
src/cluster-version.ts 84.61% <0.00%> (+30.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9c474...6b45092. Read the comment docs.

@sudhirverma
Copy link
Contributor

I am getting an option to install pipeline as clustertask
Screenshot 2021-11-12 at 2 15 20 PM

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob
Copy link
Collaborator Author

@sudhirverma That should be removed now.

@sudhirverma
Copy link
Contributor

clicking on uninstall button always stays on Uninstalling stay and if you install the pipeline from editor view it does not change the state from install to uninstall.

@evidolob
Copy link
Collaborator Author

That expected, as if you install pipeline manually, the yaml doesn't contain label which indicate that pipeline from TektonHub

@sudhirverma
Copy link
Contributor

That expected, as if you install pipeline manually, the yaml doesn't contain label which indicate that pipeline from TektonHub

I have not installed it manually. I install it from tektonHub.

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob
Copy link
Collaborator Author

OK, that should be fixed now

@evidolob evidolob merged commit 645eda8 into master Nov 18, 2021
@evidolob evidolob deleted the install-pipeline-from-hub branch November 18, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to install pipelines from Hub
3 participants