-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug on finding reference resource while deleting #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By looking at the code it looks good now. Added some ideas to improve it.
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 68.28% 68.25% -0.04%
==========================================
Files 96 96
Lines 5774 5781 +7
Branches 1002 1003 +1
==========================================
+ Hits 3943 3946 +3
- Misses 1831 1835 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works fine. Some more comments/ideas below that came to my mind by looking at the code. But it works the same as it is.
No description provided.