Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating latest changes and removing unwanted images from Readme.md #79

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

athirakm94
Copy link
Contributor

Updating latest changes
Removing unwanted images from Readme.md

@fbricon
Copy link
Collaborator

fbricon commented Oct 14, 2024

build fails because:

Error: SVGs are restricted in README.md; please use other file image formats, such as PNG: https://github.com/redhat-developer/vscode-granite/raw/HEAD/media/workflow.svg

README.md Outdated
Comment on lines 33 to 34
##### Workflow of Vscode-Granite
![workflow](media/workflow.svg)
Copy link
Collaborator

@fbricon fbricon Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary at all

step 3: **Install granite models**

select the Granite model you wish to install. Follow the on-screen instruction to complete the setup of your models.
![installmodels](media/installmodels.gif)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the gif is stale, we should see the option to keep existing settings in the combo

Copy link
Collaborator

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @athirakm94. This is a good starting point. We'll certainly make some improvements later though.

@fbricon fbricon merged commit 6a7e76b into redhat-developer:main Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants