changed user information popup through vscode showInformationMessage #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SachinS10-lab
commented
Oct 30, 2024
•
SachinS10-lab
commented
- Added chat model selection user information popup in configureAssistant.ts file.
- Added welcome user information popup in setupGranitePage.ts
fbricon
requested changes
Oct 31, 2024
src/panels/setupGranitePage.ts
Outdated
Comment on lines
246
to
253
| // Check if we should show the Continue Onboarding message | ||
| const shouldShowContinueOnboarding = await this.shouldShowContinueOnboarding(); | ||
| if (shouldShowContinueOnboarding) { | ||
| vscode.window.showInformationMessage( | ||
| `Upon launching Continue AI code Assistant, A Quickstart Popup will be displayed. | ||
| Make sure to close it before setting up IBM Granite Code Models.`, | ||
| `` | ||
| ); |
There was a problem hiding this comment.
no, this message will only be shown once configuration is done
src/panels/setupGranitePage.ts
Outdated
Comment on lines
217
to
227
| private async shouldShowContinueOnboarding(): Promise<boolean> { | ||
| const config = await readConfig(configFilePath); | ||
| if (!config || !config.models) { | ||
| vscode.window.showErrorMessage(`No Models Found!`); | ||
| return false; | ||
| } | ||
| return config.models.length === 1 && | ||
| config.models[0].provider === "anthropic" && | ||
| config.models[0].apiKey === ""; | ||
| } | ||
|
|
src/configureAssistant.ts
Outdated
| public async openWizard() { | ||
| if (isContinueInstalled()) { | ||
| vscode.window.showInformationMessage( |
There was a problem hiding this comment.
only display if mightShowContinueOnboarding returns true
There was a problem hiding this comment.
also, run this popup only after calling this.configureAssistant();
src/configureAssistant.ts
Outdated
| @@ -103,8 +103,23 @@ export class AiAssistantConfigurator { | |||
| this.apiBase = DEFAULT_API_BASE; | |||
| } | |||
|
|
|||
| private async shouldShowContinueOnboarding(configFile: string): Promise<boolean> { | |||
There was a problem hiding this comment.
rename to mightShowContinueOnboarding
There was a problem hiding this comment.
Changed all mentioned changes and now working as expected.
When mightShowContinueOnboarding become true.
When mightShowContinueOnboarding become false.
Signed-off-by: sachinsuresh-s10 <[email protected]>
fbricon
force-pushed
the
user-info-popup-chatmodel
branch
2 times, most recently
from
674b11f
to
fc63518
Compare
Signed-off-by: sachinsuresh-s10 <[email protected]>
fbricon
force-pushed
the
user-info-popup-chatmodel
branch
from
fc63518
to
c9e2944
Compare
|
Thanks @SachinS10-lab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.