First drop of react unit tests #111
Closed
+7,336
−550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fbricon the CI build failure is because there are conflicting type definitions between the installed versions of @types/mocha and @types/jest. Since I am using Jest for testing, can I remove @types/mocha from devDependencies? |
Closed
fbricon
requested changes
Oct 26, 2024
package.json
Outdated
| ], | ||
| "moduleNameMapper": { | ||
| "\\.(css|less|scss|sass)$": "identity-obj-proxy" | ||
| } |
There was a problem hiding this comment.
those changes seem unnecessary, since the tests only affect the webviews/ package
package.json
Outdated
Comment on lines
65
to
66
| "test:jest": "jest", | ||
| "test:ci": "jest --ci --reporters=default --reporters=jest-junit" |
There was a problem hiding this comment.
this should delegate the jest tests from the webviews package
webviews/src/StatusCheck.tsx
Outdated
| @@ -1,5 +1,5 @@ | |||
| import { VscArrowCircleDown, VscCircleLarge, VscCircleLargeFilled, VscPass, VscPassFilled } from "react-icons/vsc"; | |||
|
|
|||
| import React from 'react'; | |||
| @@ -6,6 +6,7 @@ import { ProgressData } from "../../src/commons/progressData"; | |||
| import { getStandardName } from "../../src/commons/naming"; | |||
| import { ModelStatus, ServerStatus } from "../../src/commons/statuses"; | |||
| import { StatusCheck, StatusValue } from "./StatusCheck"; | |||
| import React from 'react'; | |||
Signed-off-by: Neehar Kurukunda <[email protected]>
fbricon
reviewed
Oct 29, 2024
package.json
Outdated
| "test": "vscode-test" | ||
| "test": "vscode-test", | ||
| "test:jest": "cd webviews && npm run test", | ||
| "test:ci": "cd webviews && jest --ci --reporters=default --reporters=jest-junit" |
fbricon
reviewed
Oct 29, 2024
webviews/src/ProgressBar.test.tsx
Outdated
| @@ -2,7 +2,7 @@ import { render, screen } from '@testing-library/react'; | |||
| import ProgressBar from './ProgressBar'; | |||
| import { ProgressData } from '../../src/commons/progressData'; | |||
| import '@testing-library/jest-dom'; | |||
| import React from 'react'; | |||
| //import React from 'react'; | |||
|
the build fails and there are conflicts to fix |
Signed-off-by: Neehar Kurukunda <[email protected]>
|
Closing the PR as this is addressed in #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to: #49