Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart web view stuck when opening the second time #3623

Conversation

msivasubramaniaan
Copy link
Collaborator

Fixes: #3622

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (aec13a8) 34.23% compared to head (5d9171a) 34.22%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/webview/helm-chart/helmChartLoader.ts 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3623      +/-   ##
==========================================
- Coverage   34.23%   34.22%   -0.01%     
==========================================
  Files          82       82              
  Lines        5857     5858       +1     
  Branches     1172     1171       -1     
==========================================
  Hits         2005     2005              
- Misses       3852     3853       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bug for me. Thanks, Muthu!

@datho7561 datho7561 merged commit 2a4f594 into redhat-developer:main Nov 24, 2023
4 of 6 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 3622-helm-chart-search-is-stuck-loading-if-you-close-then-reopen-it branch November 24, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Chart search is stuck loading if you close then reopen it
2 participants