Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding create component from local codebase UI test #3599

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Adding create component from local codebase UI test #3599

merged 1 commit into from
Nov 21, 2023

Conversation

lgrossma
Copy link
Contributor

See: #3067

@lgrossma lgrossma marked this pull request as draft November 18, 2023 21:48
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9824048) 34.23% compared to head (39e94d8) 34.23%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3599   +/-   ##
=======================================
  Coverage   34.23%   34.23%           
=======================================
  Files          82       82           
  Lines        5847     5847           
  Branches     1171     1171           
=======================================
  Hits         2002     2002           
  Misses       3845     3845

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgrossma lgrossma force-pushed the createComp branch 3 times, most recently from 274f3d9 to f89620d Compare November 21, 2023 15:48
@lgrossma lgrossma marked this pull request as ready for review November 21, 2023 16:02
@lgrossma lgrossma requested a review from datho7561 November 21, 2023 16:02
datho7561
datho7561 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The test is passing consistently locally for me!

@datho7561 datho7561 merged commit a99f237 into redhat-developer:main Nov 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
component/ui-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgrossma @datho7561