Exclude **/node_modules/** from .java files search

[gluxon]

This is a strange PR and I would have no qualms with it being rejected.

Similar to microsoft/vscode-java-debug#1234, I'm hoping to ignore node_modules to prevent large CPU usage from this extension when my teammates open a Node.js project. There's details in the linked pull request, but happy to elaborate if there's questions. Thanks!

Specifically, we're seeing this process run for long periods of time. It's searching on /{src, test}/**/*.java.

❯ ps x | grep ripgrep
93718   ??  R      0:16.30 /Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar.unpacked/@vscode/ripgrep/bin/rg --files --hidden --case-sensitive --no-require-git -g /{src, test}/**/*.java -g !**/.git -g !**/.svn -g !**/.hg -g !**/CVS -g !**/.DS_Store -g !**/Thumbs.db --no-ignore --no-config

[rgrunber]

This is actually pretty reasonable. We have such logic on the language server side.

https://github.com/eclipse-jdtls/eclipse.jdt.ls/blob/317c78e09b863ef48a1d5c63fa22af7ee43d08f6/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java#L680-L683
https://github.com/eclipse-jdtls/eclipse.jdt.ls/blob/317c78e09b863ef48a1d5c63fa22af7ee43d08f6/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java#L706

I was thinking of adding .git/ in there but apparently the improvement is negligible.

[jdneo]

This utility method might help (there is a type of the method name, should be glob instead of blob):

vscode-java/src/utils.ts

Lines 101 to 111 in 4cb7a84

	const config = getJavaConfiguration();
	const exclusions: string[] = config.get<string[]>("import.exclusions", []);
	const patterns: string[] = [];
	for (const exclusion of exclusions) {
	if (exclusion.startsWith("!")) {
	continue;
	}
	patterns.push(exclusion);
	}
	return parseToStringGlob(patterns);

[gluxon]

@jdneo Is the recommendation to read the java.import.exclusions config and use it as the exclusionGlob here?

If so, I'd just want to double check a quick question before making changes in this PR. I think I could see a developer wanting certain .java files in java.import.exclusions to still be a trigger that activates the language server, but not be included in imports?

Thanks for the typo catch. Fixed in latest push.

[jdneo]

I think I could see a developer wanting certain .java files in java.import.exclusions to still be a trigger that activates the language server, but not be included in imports?

The extension will always be activated if a Java file is opened, which is defined here: https://github.com/redhat-developer/vscode-java/blob/master/package.json#L42

My understanding of this case is: The trigger files is used as an indicator of the project importer: https://github.com/eclipse-jdtls/eclipse.jdt.ls/blob/7e07649d7a9aee1872e5494b19e650058a577f55/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/InvisibleProjectImporter.java#L735. If the user has already added a path into that setting, it means the user does not want to import anything from that folder. So, using that setting should be ok.

[gluxon]

Thanks for the help @jdneo! The latest push now reuses the getExclusionsBlob() function. I attempted to describe why this change makes sense as a comment. Would appreciate a double check that comment is correct.

As for testing, I double checked this code path still finds a Test.java file at the root of the project if build.gradle is opened.

[jdneo]

LGTM!