Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Java 17 #2495

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Move to Java 17 #2495

merged 1 commit into from
Jun 8, 2022

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Jun 6, 2022

Requires eclipse-jdtls/eclipse.jdt.ls#2118

Signed-off-by: Snjezana Peco [email protected]

@rgrunber
Copy link
Member

rgrunber commented Jun 6, 2022

Thanks for doing this. There's also a reference inside pr-verify.yml that should be updated. I'm not sure about .sdkmanrc but I suspect that as well. May need to figure out what the proper version is through there.

@snjeza
Copy link
Contributor Author

snjeza commented Jun 6, 2022

There's also a reference inside pr-verify.yml

Fixed.

@snjeza
Copy link
Contributor Author

snjeza commented Jun 6, 2022

test this please

@rgrunber
Copy link
Member

rgrunber commented Jun 8, 2022

Can we also just change the .sdkmanrc to contain 17.0.3-tem . I think that should be the version from Adoptium. Otherwise, I think this is ready to be merged.

@rgrunber
Copy link
Member

rgrunber commented Jun 8, 2022

We should also update https://github.com/redhat-developer/vscode-java/wiki/JDK-Requirements on the wiki page once this is merged.

Signed-off-by: Snjezana Peco <[email protected]>
@snjeza
Copy link
Contributor Author

snjeza commented Jun 8, 2022

Can we also just change the .sdkmanrc to contain 17.0.3-tem . I think that should be the version from Adoptium. Otherwise, I think this is ready to be merged.

@rgrunber I have updated the PR.

@snjeza snjeza merged commit 1830d4d into redhat-developer:master Jun 8, 2022
@snjeza
Copy link
Contributor Author

snjeza commented Jun 8, 2022

We should also update https://github.com/redhat-developer/vscode-java/wiki/JDK-Requirements on the wiki page once this is merged.

@rgrunber I have updated it.

@rgrunber rgrunber added this to the End June 2022 milestone Jun 8, 2022
@afriza
Copy link

afriza commented Sep 13, 2022

Which last extension version supports < JavaSE-17 ? v1.7.0?
Because of extension auto-update, I get the install JDK 17 prompt.

@rgrunber
Copy link
Member

Which last extension version supports < JavaSE-17 ? v1.7.0? Because of extension auto-update, I get the install JDK 17 prompt.

Yes, 1.7.0 would be the last version that can be started with a Java runtime less than version 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants