Find references to fields via getters/setters #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
reviewed
Oct 8, 2020
There was a problem hiding this comment.
@fbricon should we wait a day for results of https://twitter.com/VSCodeJava/status/1314145144791236608 , or are you fine with disabled by default ?
Change looks fine to me overall.
|
Whoops, meant to re-review myself. @snjeza I think this is fine to merge. We can always revisit the default value at a later time. |
fbricon
requested changes
Oct 13, 2020
README.md
Outdated
| @@ -171,6 +171,9 @@ The following settings are supported: | |||
| * `java.templates.fileHeader`: Specifies the file header comment for new Java file. Supports configuring multi-line comments with an array of strings, and using ${variable} to reference the [predefined variables](https://github.com/redhat-developer/vscode-java/wiki/Predefined-Variables-for-Java-Template-Snippets). | |||
| * `java.templates.typeComment`: Specifies the type comment for new Java type. Supports configuring multi-line comments with an array of strings, and using ${variable} to reference the [predefined variables](https://github.com/redhat-developer/vscode-java/wiki/Predefined-Variables-for-Java-Template-Snippets). | |||
|
|
|||
| New in 0.68.0: | |||
| * `java.references.includeGetterSetter`: Include getter, setter and builder/constructor when finding references. | |||
There was a problem hiding this comment.
java.references.includeAccessors
Signed-off-by: Snjezana Peco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See eclipse-jdtls/eclipse.jdt.ls#1548
Requires eclipse-jdtls/eclipse.jdt.ls#1561
Signed-off-by: Snjezana Peco [email protected]