Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR test for 1.1.x branch #999

Merged
merged 9 commits into from
Feb 26, 2024
Merged

Conversation

josephca
Copy link
Contributor

@josephca josephca commented Feb 22, 2024

Description

The current PR test is running only when the target is the 'main' branch. The same e2e test should be running for PRs for 1.1.x branch. Add additional test stage in the pipeline.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-999!

@josephca josephca removed request for a team, Zaperex and rnapoles-rh February 22, 2024 20:55
@josephca josephca changed the title [WIP] Test PR test run on 1.1.x [WIP] PR test run on 1.1.x Feb 22, 2024
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-999!

Copy link
Contributor

janus-idp bot commented Feb 22, 2024

backstage-showcase Tests on commit 19a3ab8 finished successfully.
View test log

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@josephca josephca changed the title [WIP] PR test run on 1.1.x Add PR test for 1.1.x branch Feb 22, 2024
@josephca josephca self-assigned this Feb 22, 2024
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-999!

Copy link

openshift-ci bot commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gustavolira
Once this PR has been reviewed and has the lgtm label, please ask for approval from josephca. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josephca josephca merged commit edc1b4e into redhat-developer:1.1.x Feb 26, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants