Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): downgrade scalprum #915

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix(deps): downgrade scalprum #915

merged 1 commit into from
Jan 25, 2024

Conversation

schultzp2020
Copy link
Collaborator

@schultzp2020 schultzp2020 commented Jan 25, 2024

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Paul Schultz <[email protected]>
@schultzp2020 schultzp2020 requested a review from a team as a code owner January 25, 2024 21:34
Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: d51feb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@openshift-ci openshift-ci bot requested review from davidfestal and Zaperex January 25, 2024 21:34
@Zaperex
Copy link
Contributor

Zaperex commented Jan 25, 2024

/lgtm
/approve

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Zaperex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@schultzp2020 schultzp2020 merged commit 77abab3 into main Jan 25, 2024
4 of 6 checks passed
@schultzp2020 schultzp2020 deleted the downgrade-scalprum branch January 25, 2024 21:35
Copy link
Contributor

janus-idp bot commented Jan 25, 2024

backstage-showcase Tests on commit finished with errors.
View test log

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-915!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The showcase doesn't start locally when running yarn start
2 participants