style: reorder imports via prettier #286
Conversation
Signed-off-by: Paul Schultz <[email protected]>
|
…into import-order
packages/app/src/App.tsx
Outdated
| <Route | ||
| path="/tech-radar" | ||
| element={<TechRadarPage width={1500} height={800} id="default" />} | ||
| /> | ||
| <Route path="/tech-radar" element={<TechRadarPage width={1500} height={800} id="default" />} /> |
There was a problem hiding this comment.
So I see that a lot of these have been collapsed, I don't really have a preference either way but I wonder what other people think about the difference between the two? @christophe-f
There was a problem hiding this comment.
Personally I think having print width of 100 characters is better because we are working on screens that can support more than 80 characters lol.
Signed-off-by: Paul Schultz <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
@christophe-f We have already merged a PR like this in janus-idp/backstage-plugins#419. The only changes with this PR is to the import order and it does not diverge in anything else from the upstream. |
Description
Please explain the changes you made here.
Reorders the imports to maintain parity with the janus plugins repo. janus-idp/backstage-plugins#419
Which issue(s) does this PR fix
N/A
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer