chore(wrapper): add wrapper for marketplace frontend, backend and catalog-backend-module plugins #2156
Conversation
karthikjeeyar
force-pushed
the
add-marketplace-wrapper
branch
7 times, most recently
from
62d25cc to
0c4d778
Compare
|
/test e2e-tests |
|
The image is available at: |
karthikjeeyar
force-pushed
the
add-marketplace-wrapper
branch
from
d1f2829 to
4235077
Compare
|
The image is available at: |
| @@ -1010,3 +1010,26 @@ plugins: | |||
| catalog: | |||
| providers: | |||
| pingIdentityOrg: {} | |||
| # Group: Marketplace | |||
| - package: ./dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-catalog-backend-module-marketplace-dynamic | |||
| disabled: true | |||
...d-hat-developer-hub-backstage-plugin-catalog-backend-module-marketplace-dynamic/package.json
Outdated
Show resolved
Hide resolved
...ins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace-backend-dynamic/package.json
Outdated
Show resolved
Hide resolved
...ugins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace-backend-dynamic/turbo.json
Outdated
Show resolved
Hide resolved
dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace/package.json
Outdated
Show resolved
Hide resolved
dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace/turbo.json
Outdated
Show resolved
Hide resolved
|
The image is available at: |
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/janus-idp/backstage-showcase", |
There was a problem hiding this comment.
Reminder for myself: we need to update this
| "directory": "dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace" | ||
| }, | ||
| "maintainers": [ | ||
| "@janus-idp/maintainers-showcase" |
There was a problem hiding this comment.
Reminder for myself: we need to update this
|
/retest |
2 similar comments
|
/retest |
|
/retest |
plugins/dynamic-plugins-info/src/components/InternalPluginsMap.ts
Outdated
Show resolved
Hide resolved
karthikjeeyar
force-pushed
the
add-marketplace-wrapper
branch
from
d43de66 to
69e1b75
Compare
|
The image is available at: |
|
This lgtm, just waiting for for e2e tests after we migrated this git repo. Will add lgtm label then. |
|
/retest |
1 similar comment
|
/retest |
karthikjeeyar
force-pushed
the
add-marketplace-wrapper
branch
from
69e1b75 to
3f78322
Compare
karthikjeeyar
force-pushed
the
add-marketplace-wrapper
branch
from
3f78322 to
90129ae
Compare
karthikjeeyar
force-pushed
the
add-marketplace-wrapper
branch
from
90129ae to
58ddacc
Compare
|
The image is available at: |
There was a problem hiding this comment.
Thanks @karthikjeeyar
I've verified this PR with quay.io/rhdh-community/rhdh:pr-2156-58ddacc5
I started an instance without and with enabling the marketplace plugin. Both worked fine. 👍
My helm chart: https://github.com/christoph-jerolimov/rhdh-helm-charts/blob/main/prs/2156/values.yaml
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christoph-jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
openshift-merge-bot
bot
merged commit 27012ad
into
redhat-developer:main
Description
Add dynamic plugin wrappers for marketplace, marketplace-backend and catalog-backend-module-marketplace plugins.
Which issue(s) does this PR fix
https://issues.redhat.com/browse/RHIDP-5322
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer