Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.x] chore(admin): enable dynamic-plugins-info #1060

Conversation

openshift-cherrypick-robot
Copy link
Contributor

@openshift-cherrypick-robot openshift-cherrypick-robot commented Mar 8, 2024

This is an automated cherry-pick of #1057

/assign gashcrumb

This change enables the dynamic-plugins-info UI by default when
installing the app via helm  or operator.

Signed-off-by: Stan Lewis <[email protected]>
Copy link
Contributor

github-actions bot commented Mar 8, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1060!

Copy link
Contributor

janus-idp bot commented Mar 8, 2024

backstage-showcase Tests on commit fb7a33e finished successfully.
View test log

@gashcrumb
Copy link
Member

/retest

Copy link
Contributor

github-actions bot commented Mar 8, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1060!

@gashcrumb
Copy link
Member

gashcrumb commented Mar 8, 2024

@nickboldt I don't see a bot command to rebase this branch, is there one that I'm missing? Looks like I can't push to the bot's branch either. Worst case I guess we can close this one and generate a new cherry pick PR? We'll need to do this to see the tests passing with this change.

@openshift-ci openshift-ci bot removed the lgtm label Mar 8, 2024
Copy link

openshift-ci bot commented Mar 8, 2024

New changes are detected. LGTM label has been removed.

Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Mar 8, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1060!

@gashcrumb gashcrumb added the lgtm label Mar 8, 2024
@gashcrumb
Copy link
Member

gashcrumb commented Mar 8, 2024

It updates the existing comment with the test log, but I wonder if there's still an issue to look into updating the status:

image

@nickboldt
Copy link
Member

/lgtm
/approve
/geez can we merge this already

@gashcrumb
Copy link
Member

Yep, I think that's probably a good thing 😄

Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c51f907 into redhat-developer:1.1.x Mar 8, 2024
7 checks passed
@nickboldt
Copy link
Member

I love it when automation falls on its face..."everything is good" but also "no it isn't"

image

@nickboldt
Copy link
Member

rebuilding in 1.1 branch from https://gitlab.cee.redhat.com/rhidp/rhdh/-/pipelines/7668875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants