Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to 1.23.4 #1051

Merged
merged 3 commits into from
Mar 5, 2024
Merged

chore(deps): upgrade to 1.23.4 #1051

merged 3 commits into from
Mar 5, 2024

Conversation

schultzp2020
Copy link
Collaborator

@schultzp2020 schultzp2020 commented Mar 4, 2024

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@schultzp2020 schultzp2020 requested a review from a team as a code owner March 4, 2024 19:17
@openshift-ci openshift-ci bot requested review from tumido and Zaperex March 4, 2024 19:17
Copy link

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from schultzp2020. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Paul Schultz <[email protected]>
Copy link
Contributor

github-actions bot commented Mar 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1051!

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit but I bet we need to bump the plugin versions again once they're rebuilt in https://github.com/janus-idp/backstage-plugins/ against Backstage 1.23.4?

Copy link
Contributor

janus-idp bot commented Mar 4, 2024

backstage-showcase Tests on commit 2a1ca08 finished with errors.
View test log

@nickboldt
Copy link
Member

janus-idp/backstage-plugins#1307 merged, waiting for rebase...

@nickboldt nickboldt closed this Mar 4, 2024
@nickboldt nickboldt reopened this Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1051!

Signed-off-by: Paul Schultz <[email protected]>
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Mar 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1051!

@nickboldt nickboldt merged commit 67f9c53 into main Mar 5, 2024
5 of 7 checks passed
nickboldt added a commit that referenced this pull request Mar 5, 2024
nickboldt added a commit that referenced this pull request Mar 5, 2024
@schultzp2020 schultzp2020 deleted the upgrade-1.23.4 branch April 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants