Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update packages #1044

Merged
merged 1 commit into from
Feb 29, 2024
Merged

chore(deps): update packages #1044

merged 1 commit into from
Feb 29, 2024

Conversation

schultzp2020
Copy link
Collaborator

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Paul Schultz <[email protected]>
@schultzp2020 schultzp2020 requested a review from a team as a code owner February 29, 2024 15:12
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more chnages than just bumping the rbac plugin version, but if these are all security updates and necessary version bumps, then +1

Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt
Copy link
Member

/cherry-pick 1.1.x

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: once the present PR merges, I will cherry-pick it on top of 1.1.x in a new PR and assign it to you.

In response to this:

/cherry-pick 1.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1044!

@openshift-merge-bot openshift-merge-bot bot merged commit 0947566 into main Feb 29, 2024
6 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the update-packages branch February 29, 2024 15:41
@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: #1044 failed to apply on top of branch "1.1.x":

Applying: chore(deps): update packages
Using index info to reconstruct a base tree...
M	packages/backend/package.json
M	yarn.lock
Falling back to patching base and 3-way merge...
Auto-merging yarn.lock
CONFLICT (content): Merge conflict in yarn.lock
Auto-merging packages/backend/package.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 chore(deps): update packages
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick 1.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

schultzp2020 added a commit that referenced this pull request Feb 29, 2024
kadel pushed a commit to kadel/backstage-showcase that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants