Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test infra] Enable manual trigger of e2e test #1006

Merged
merged 11 commits into from
Feb 26, 2024

Conversation

josephca
Copy link
Contributor

@josephca josephca commented Feb 26, 2024

Description

To trigger e2e tests manually, an additional stage needs to be created. Currently, e2e tests can be triggered only through a PR.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@josephca josephca requested review from gustavolira and removed request for invincibleJai February 26, 2024 15:52
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1006!

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like a no-op change here, so I would approve it but you have "WIP" on this PR, and no linked JIRA.

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1006!

Copy link
Contributor

janus-idp bot commented Feb 26, 2024

backstage-showcase Tests on commit 0d5f656 finished with errors.
View test log

@josephca josephca changed the title [WIP] Test run for 1.1.x e2e tests [Test infra] Enable manual trigger of e2e test Feb 26, 2024
@josephca
Copy link
Contributor Author

feels like a no-op change here, so I would approve it but you have "WIP" on this PR, and no linked JIRA.

I had "WIP" as it wasn't ready to be reviewed yet. :) Please review when you can. Thanks!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1006!

@josephca josephca requested a review from nickboldt February 26, 2024 20:00
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@rnapoles-rh rnapoles-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rnapoles-rh
Copy link

/approve

@@ -31,6 +31,12 @@ EOF

skip_if_only() {
echo "Checking if tests need to be executed..."

if [[ ${SKIP_TEST,,} == "false" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming bash 4 is installed, this seems reasonable but could also do

Suggested change
if [[ ${SKIP_TEST,,} == "false" ]]; then
if [[ $(echo ${SKIP_TEST} | tr "A-Z" "a-z") == "false" ]]; then

.ibm/pipelines/functions.sh Show resolved Hide resolved
Copy link

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt, rnapoles-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1006!

@openshift-merge-bot openshift-merge-bot bot merged commit 901ac48 into redhat-developer:1.1.x Feb 26, 2024
6 checks passed
@josephca josephca deleted the test1.1.x branch March 4, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants