-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test infra] Enable manual trigger of e2e test #1006
[Test infra] Enable manual trigger of e2e test #1006
Conversation
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like a no-op change here, so I would approve it but you have "WIP" on this PR, and no linked JIRA.
The image is available at: |
I had "WIP" as it wasn't ready to be reviewed yet. :) Please review when you can. Thanks! |
The image is available at: |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
@@ -31,6 +31,12 @@ EOF | |||
|
|||
skip_if_only() { | |||
echo "Checking if tests need to be executed..." | |||
|
|||
if [[ ${SKIP_TEST,,} == "false" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming bash 4 is installed, this seems reasonable but could also do
if [[ ${SKIP_TEST,,} == "false" ]]; then | |
if [[ $(echo ${SKIP_TEST} | tr "A-Z" "a-z") == "false" ]]; then |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nickboldt, rnapoles-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
901ac48
into
redhat-developer:1.1.x
Description
To trigger e2e tests manually, an additional stage needs to be created. Currently, e2e tests can be triggered only through a PR.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer