fix margin in back button #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lior Soffer <[email protected]>
LiorSoffer
requested review from
batzionb,
mareklibra and
gciavarrini
as code owners
Changed Packages
|
batzionb
approved these changes
Dec 22, 2024
batzionb
reviewed
Dec 22, 2024
| @@ -35,6 +35,7 @@ | |||
| "dependencies": { | |||
| "@backstage/core-components": "^0.15.1", | |||
| "@backstage/core-plugin-api": "^1.10.0", | |||
| "@backstage/types": "^1.1.1", | |||
There was a problem hiding this comment.
I missed this in the review
Can you please revert this change?
There was a problem hiding this comment.
I can't pass the prettier tests without this change
There was a problem hiding this comment.
I'll take a look to understand why
Meanwhile leave it as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve FLPATH-1884