Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestrator): add runs button #213

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

LiorSoffer
Copy link
Contributor

@LiorSoffer LiorSoffer commented Dec 19, 2024

reslove FLPATH-1888

image
right button added - routing to all instances of this specific workflow:

image

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Dec 19, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-orchestrator workspaces/orchestrator/plugins/orchestrator patch v2.5.0

fix
Signed-off-by: Lior Soffer <[email protected]>
@gciavarrini
Copy link
Contributor

Can you please add a screenshot to quick understand the changes?

@LiorSoffer
Copy link
Contributor Author

@gciavarrini added screenshot :)

@batzionb
Copy link
Contributor

batzionb commented Dec 22, 2024

@LiorSoffer
The breadcrumb isn't correct, the first part should be a link, the second the instance ID
image
Notice this is how it used to be
image

@batzionb
Copy link
Contributor

batzionb commented Dec 22, 2024

@LiorSoffer
This PR includes three things -

  1. adding the button to the table navigating to the instance
  2. renaming the tab and breadcrumb to All runs
  3. the breadcrumb change - which isn't correct

Can you please just commit first?
Let's leave the breadcrumb change for now

Signed-off-by: Lior Soffer <[email protected]>
@batzionb batzionb dismissed mareklibra’s stale review December 22, 2024 19:36

the change you requested is no longer relevant, the breadcrumb changes were removed

@batzionb batzionb merged commit be7b8c9 into redhat-developer:main Dec 22, 2024
7 checks passed
@LiorSoffer LiorSoffer deleted the runsButton branch December 29, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants