fix(theme): match tabs style with PF design #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Cai <[email protected]>
Changed Packages
|
Comment on lines
+427
to
+434
| '& > div > div > button[class*="v5"]': { | ||
| alignItems: 'baseline', | ||
| textAlign: 'left', | ||
| }, | ||
| '& > div > div > button > span': { | ||
| alignItems: 'baseline', | ||
| textAlign: 'left', | ||
| }, |
There was a problem hiding this comment.
A small thing we could improve later. You can also use a class selector like this:
Suggested change
| '& > div > div > button[class*="v5"]': { | |
| alignItems: 'baseline', | |
| textAlign: 'left', | |
| }, | |
| '& > div > div > button > span': { | |
| alignItems: 'baseline', | |
| textAlign: 'left', | |
| }, | |
| // MUI v5 | |
| '& > div > div > button.v5-MuiTab-root': { | |
| alignItems: 'baseline', | |
| textAlign: 'left', | |
| }, | |
| // MUI v4 | |
| '& > div > div > button > span': { | |
| alignItems: 'baseline', | |
| textAlign: 'left', | |
| }, |
christoph-jerolimov
approved these changes
Dec 6, 2024
| }, | ||
| }, | ||
| indicator: { | ||
| left: 0, |
There was a problem hiding this comment.
Also if I don't see an issue with the current solution, its better if we could unset right here:
Suggested change
| left: 0, | |
| left: 0, | |
| right: unset, |
5 tasks
04kash
pushed a commit
to 04kash/rhdh-plugins
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Yi Cai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
For RHIDP-5176,
✔️ Checklist
Before
After
rhidp_5176_fix.mp4