fix(theme): fixed that all disabled elements used a disable background color instead of just disabled tabs #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
ciiay
requested changes
Dec 4, 2024
| @@ -436,7 +436,7 @@ export const createComponents = (themeConfig: ThemeConfig): Components => { | |||
| root: { | |||
| textTransform: 'none', | |||
| minWidth: 'initial !important', | |||
| '&.Mui-disabled': { | |||
| '&:disabled': { | |||
| backgroundColor: general.disabledBackground, | |||
There was a problem hiding this comment.
Suggested change
| backgroundColor: general.disabledBackground, | |
| backgroundColor: 'unset', |
⬆️ fixes the following issue with tab button background color being gray.
There was a problem hiding this comment.
Then I can just remove this disabled code. I thought setting a gray background to the tab was exactly what we want to make it more clear that the tab is disabled.
With just the different text Color is really hard to see if a tab is disabled. I will check with @ShiranHi and the PF 5/6 documentation.
There was a problem hiding this comment.
There was a problem hiding this comment.
Right, let's follow PF guidelines. Do they use the same gray color for both light and dark mode?
…d color instead of just disabled tabs Signed-off-by: Christoph Jerolimov <[email protected]>
christoph-jerolimov
force-pushed
the
fix-disabled-background-color
branch
from
5faeb4b to
249c5fa
Compare
christoph-jerolimov
added a commit
to christoph-jerolimov/rhdh-plugins
that referenced
this pull request
Dec 5, 2024
…per#122 was merged Signed-off-by: Christoph Jerolimov <[email protected]>
4 tasks
5 tasks
christoph-jerolimov
added a commit
that referenced
this pull request
Dec 6, 2024
…elevations (#126) * fix(theme): fix/remove different paper background colors/shades in MUI v5 Signed-off-by: Christoph Jerolimov <[email protected]> * fix(theme): remove unused Mui-Disabled workaround after #122 was merged Signed-off-by: Christoph Jerolimov <[email protected]> * fix(theme): replace the paper shadow and added a border to all paper elevations Signed-off-by: Christoph Jerolimov <[email protected]> --------- Signed-off-by: Christoph Jerolimov <[email protected]>
04kash
pushed a commit
to 04kash/rhdh-plugins
that referenced
this pull request
Dec 12, 2024
…d color instead of just disabled tabs (redhat-developer#122) Signed-off-by: Christoph Jerolimov <[email protected]>
04kash
pushed a commit
to 04kash/rhdh-plugins
that referenced
this pull request
Dec 12, 2024
…elevations (redhat-developer#126) * fix(theme): fix/remove different paper background colors/shades in MUI v5 Signed-off-by: Christoph Jerolimov <[email protected]> * fix(theme): remove unused Mui-Disabled workaround after redhat-developer#122 was merged Signed-off-by: Christoph Jerolimov <[email protected]> * fix(theme): replace the paper shadow and added a border to all paper elevations Signed-off-by: Christoph Jerolimov <[email protected]> --------- Signed-off-by: Christoph Jerolimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
TODO
✔️ Checklist