fix(orchestrator): fix status filter (#162)

redhat-developer · Dec 12, 2024 · cf1c024 · cf1c024
1 parent 562a850
commit cf1c024
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/workspaces/orchestrator/.changeset/swift-cats-pull.md b/workspaces/orchestrator/.changeset/swift-cats-pull.md
@@ -0,0 +1,5 @@
+---
+'@red-hat-developer-hub/backstage-plugin-orchestrator': patch
+---
+
+bug fix in workflow runs table status filter
diff --git a/workspaces/orchestrator/plugins/orchestrator/src/components/WorkflowRunsTabContent.tsx b/workspaces/orchestrator/plugins/orchestrator/src/components/WorkflowRunsTabContent.tsx
@@ -29,7 +29,6 @@ import { Grid } from '@material-ui/core';
 import {
   capitalize,
   ellipsis,
-  ProcessInstanceState,
   ProcessInstanceStatusDTO,
 } from '@red-hat-developer-hub/backstage-plugin-orchestrator-common';
 
@@ -45,11 +44,11 @@ import { WorkflowRunDetail } from './WorkflowRunDetail';
 
 const makeSelectItemsFromProcessInstanceValues = () =>
   [
-    ProcessInstanceState.Active,
-    ProcessInstanceState.Error,
-    ProcessInstanceState.Completed,
-    ProcessInstanceState.Aborted,
-    ProcessInstanceState.Suspended,
+    ProcessInstanceStatusDTO.Active,
+    ProcessInstanceStatusDTO.Error,
+    ProcessInstanceStatusDTO.Completed,
+    ProcessInstanceStatusDTO.Aborted,
+    ProcessInstanceStatusDTO.Suspended,
   ].map(
     (status): SelectItem => ({
       label: capitalize(status),
@@ -117,7 +116,7 @@ export const WorkflowRunsTabContent = () => {
       (value ?? []).filter(
         (row: WorkflowRunDetail) =>
           statusSelectorValue === Selector.AllItems ||
-          row.status?.toLocaleLowerCase('en-US') === statusSelectorValue,
+          row.status === statusSelectorValue,
       ),
     [statusSelectorValue, value],
   );