generated from redhat-developer/new-project-template
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] update RHBK config docs with security consideration #869
Open
JessicaJHee
wants to merge
2
commits into
redhat-developer:release-1.4
Choose a base branch
from
JessicaJHee:oidc-token-doc
base: release-1.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[release-1.4] update RHBK config docs with security consideration #869
JessicaJHee
wants to merge
2
commits into
redhat-developer:release-1.4
from
JessicaJHee:oidc-token-doc
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-869/ @ 01/22/25 21:37:06 |
/lgtm |
linfraze
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the content! A couple comments.
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
JessicaJHee
force-pushed
the
oidc-token-doc
branch
from
January 21, 2025 20:15
aeab3d6
to
8bc3b36
Compare
New changes are detected. LGTM label has been removed. |
JessicaJHee
force-pushed
the
oidc-token-doc
branch
from
January 21, 2025 20:31
8bc3b36
to
82739a4
Compare
JessicaJHee
force-pushed
the
oidc-token-doc
branch
from
January 21, 2025 20:33
82739a4
to
7a1adfd
Compare
linfraze
reviewed
Jan 21, 2025
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
linfraze
reviewed
Jan 21, 2025
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
JessicaJHee
force-pushed
the
oidc-token-doc
branch
from
January 21, 2025 20:37
7a1adfd
to
a51a462
Compare
Signed-off-by: Jessica He <[email protected]>
JessicaJHee
force-pushed
the
oidc-token-doc
branch
from
January 21, 2025 21:15
a51a462
to
e5c5eb0
Compare
linfraze
approved these changes
Jan 24, 2025
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.4
Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-4695