Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHIDP-1582: Add docs for enabling metrics collection #263

Merged
merged 1 commit into from
Jun 21, 2024
Merged

RHIDP-1582: Add docs for enabling metrics collection #263

merged 1 commit into from
Jun 21, 2024

Conversation

abrennan89
Copy link
Member

@abrennan89 abrennan89 commented Jun 6, 2024 •
edited by linfraze
Loading

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jun 6, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jun 6, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jun 6, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jun 6, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jun 6, 2024

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@abrennan89 abrennan89 changed the title [WIP] RHIDP-1582: Add docs for enabling metrics collection RHIDP-1582: Add docs for enabling metrics collection Jun 10, 2024
@rm3l
Copy link
Member

rm3l commented Jun 12, 2024

/cc @rm3l

@openshift-ci openshift-ci bot requested a review from rm3l June 12, 2024 08:41
@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

rm3l
rm3l reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last question: do we need to repeat the callouts where they are used?

modules/observability/proc-admin-enabling-metrics-ocp-operator.adoc Show resolved Hide resolved
modules/observability/proc-admin-enabling-metrics-ocp-operator.adoc Show resolved Hide resolved
modules/observability/proc-admin-enabling-metrics-ocp-operator.adoc Show resolved Hide resolved
@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@Omar-AlJaljuli
Copy link
Collaborator

There is currently an issue where if you set up your helm through the CLI, you wouldn't be able to upgrade it through the console. Would it be possible to also add a subsection that covers upgrading the helm release through the CLI?

@rm3l
Copy link
Member

rm3l commented Jun 18, 2024

There is currently an issue where if you set up your helm through the CLI, you wouldn't be able to upgrade it through the console. Would it be possible to also add a subsection that covers upgrading the helm release through the CLI?

But this is out of the scope of this PR, no? I think this would be a great suggestion for RHIDP-2614 (#287) maybe?

@Omar-AlJaljuli
Copy link
Collaborator

There is currently an issue where if you set up your helm through the CLI, you wouldn't be able to upgrade it through the console. Would it be possible to also add a subsection that covers upgrading the helm release through the CLI?

But this is out of the scope of this PR, no? I think this would be a great suggestion for RHIDP-2614 (#287) maybe?

That makes sense, I guess that it's an overarching issue that isn't specific to this pr.

Omar-AlJaljuli
Omar-AlJaljuli approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@Omar-AlJaljuli Omar-AlJaljuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

linfraze
linfraze approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

assemblies/assembly-rhdh-observability.adoc Show resolved Hide resolved
modules/observability/proc-admin-enabling-metrics-ocp-helm.adoc Show resolved Hide resolved
modules/observability/proc-admin-enabling-metrics-ocp-operator.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm 👍 label Jun 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 21, 2024

New changes are detected. LGTM label has been removed.

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@rhdh-bot
Copy link
Collaborator

PR Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-263/

@abrennan89 abrennan89 merged commit 9d01dea into redhat-developer:main Jun 21, 2024
2 checks passed
@abrennan89
Copy link
Member Author

/cherrypick 1.1.x

@abrennan89
Copy link
Member Author

/cherrypick 1.2.x

@openshift-cherrypick-robot
Copy link
Contributor

@abrennan89: #263 failed to apply on top of branch "1.1.x":

Applying: RHIDP-1582: Add docs for enabling metrics collection
Using index info to reconstruct a base tree...
M	artifacts/attributes.adoc
M	titles/admin-rhdh/title-admin.adoc
Falling back to patching base and 3-way merge...
Auto-merging titles/admin-rhdh/title-admin.adoc
CONFLICT (content): Merge conflict in titles/admin-rhdh/title-admin.adoc
Auto-merging artifacts/attributes.adoc
CONFLICT (content): Merge conflict in artifacts/attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHIDP-1582: Add docs for enabling metrics collection
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick 1.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Contributor

@abrennan89: #263 failed to apply on top of branch "1.2.x":

Applying: RHIDP-1582: Add docs for enabling metrics collection
Using index info to reconstruct a base tree...
M	artifacts/attributes.adoc
Falling back to patching base and 3-way merge...
Auto-merging artifacts/attributes.adoc
CONFLICT (content): Merge conflict in artifacts/attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHIDP-1582: Add docs for enabling metrics collection
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jun 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Omar-AlJaljuli Omar-AlJaljuli Omar-AlJaljuli approved these changes

@linfraze linfraze linfraze approved these changes

@rm3l rm3l rm3l approved these changes

Assignees

@linfraze linfraze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abrennan89 @rhdh-bot @rm3l @Omar-AlJaljuli @openshift-cherrypick-robot @linfraze