Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logic for resolving imageName as a selector in the Devfile library #6676

Closed
3 tasks done
Tracked by #6565
rm3l opened this issue Mar 23, 2023 · 5 comments · Fixed by devfile/library#172
Closed
3 tasks done
Tracked by #6565

Implement logic for resolving imageName as a selector in the Devfile library #6676

rm3l opened this issue Mar 23, 2023 · 5 comments · Fixed by devfile/library#172
Assignees
@rm3l
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/task Issue is actionable task priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Milestone
v3.11.0 🚀

Comments

@rm3l
Copy link
Member

rm3l commented Mar 23, 2023 •
edited
Loading

/kind task

See #6565 and devfile/api#985 (comment) for more context.

Implement logic for resolving imageName as a selector in the devfile/library repo.

Acceptance Criteria

  • the Devfile parser in the library should be able to scan all components (including Kubernetes manifests referenced by URIs) and match any object containing the specified image name (regardless of tag).
  • It should accept a registry string as input and return a Devfile object with all matching image names replaced by this registry
  • Non-matching images should not be changed

Links
@rm3l rm3l added this to odo Project Mar 23, 2023
@rm3l rm3l converted this from a draft issue Mar 23, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Mar 23, 2023
@rm3l rm3l mentioned this issue Mar 23, 2023
Closed
8 tasks
@rm3l
Copy link
Member Author

rm3l commented Mar 23, 2023

/kind task

Converting this into a task, as this is not user-facing.

@openshift-ci openshift-ci bot added the kind/task Issue is actionable task label Mar 23, 2023
@rm3l rm3l changed the title Image name as selector: Resolving the image name in the Devfile library Implement logic for resolving imageName as a selector in the Devfile library Mar 23, 2023
@rm3l rm3l added area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. and removed needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. labels Mar 23, 2023
@rm3l
Copy link
Member Author

rm3l commented Mar 23, 2023

/priority High

Setting the same priority as its parent user story: #6565

@openshift-ci openshift-ci bot added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Mar 23, 2023
@rm3l rm3l mentioned this issue Mar 23, 2023
Closed
4 tasks
@rm3l rm3l added this to the v3.10.0 🚀 milestone Apr 6, 2023
@rm3l rm3l moved this to In Progress 🚧 in odo Project Apr 11, 2023
@valaparthvi valaparthvi moved this from In Progress 🚧 to In Review 👀 in odo Project Apr 25, 2023
@rm3l
Copy link
Member Author

rm3l commented Apr 26, 2023

PR created in Devfile library: devfile/library#172

While we are waiting for this PR to be reviewed, I've started working on #6677.

@rm3l rm3l mentioned this issue Apr 26, 2023
Merged
5 tasks
@valaparthvi valaparthvi modified the milestones: v3.10.0 🚀, v3.11.0 🚀 May 2, 2023
@rm3l
Copy link
Member Author

rm3l commented May 15, 2023

devfile/library#172 has been merged - closing this as complete.

/close

@openshift-ci openshift-ci bot closed this as completed May 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2023

@rm3l: Closing this issue.

In response to this:

devfile/library#172 has been merged - closing this as complete.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in odo Project May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rm3l rm3l

Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/task Issue is actionable task priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
odo Project
Archived in project
Milestone
v3.11.0 🚀
Development

Successfully merging a pull request may close this issue.

Allow using image names as selectors rm3l/devfile-library
2 participants
@rm3l @valaparthvi