Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The plaintext rendering color on the completion document is too dark. #370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Jun 19, 2024

fix: The plaintext rendering color on the completion document is too dark.

Fixes #368

image

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.38%. Comparing base (83ab37a) to head (c1ec7c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   22.41%   24.38%   +1.96%     
==========================================
  Files         270      270              
  Lines        9725     9408     -317     
  Branches     1830     1734      -96     
==========================================
+ Hits         2180     2294     +114     
+ Misses       7138     6687     -451     
- Partials      407      427      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angelozerr
Copy link
Contributor Author

I'm trying to write the same lua file than initial issue but the hover doesn't send the same response (param doesn't appear), but I have tested by writing jsdoc in a ts file:

/**
 * ```lua
 function f(a:aa) -> nil
 ```
 
 ___
 ```plaintext
 params: a
 ```
 ___
 
 */
function foo() {
}

foo()

And here the result:

image

@fbricon
Copy link
Contributor

fbricon commented Jun 19, 2024

I think we should keep the code blocks. That's how intellij shows code snippets
Screenshot 2024-06-19 at 15 42 47

LSP4IJ's behavior is consistent with that.

Maybe @CppCXY's issue is the block's background seems darker on completion, compared to hover. Not sure what we can do about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong code block renderer when documentation contains CLRF
2 participants