Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow message limits (#82) #85

Merged
merged 4 commits into from
Jul 18, 2024
Merged

feat: allow message limits (#82) #85

merged 4 commits into from
Jul 18, 2024

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Jun 10, 2024 •
edited
Loading

fixes #82

@adietish adietish marked this pull request as draft June 10, 2024 10:46
@adietish adietish changed the title allow message limits (#82) feat: allow message limits (#82) Jun 10, 2024
@adietish adietish force-pushed the issue-82 branch 18 times, most recently from 0c4cc1b to bf02f3c Compare June 14, 2024 18:29
@adietish adietish self-assigned this Jun 17, 2024
@adietish adietish force-pushed the issue-82 branch 8 times, most recently from 8b25f9a to 0c5a310 Compare June 18, 2024 19:40
@adietish adietish requested review from sbouchet and removed request for sbouchet June 27, 2024 14:31
@adietish adietish force-pushed the issue-82 branch 6 times, most recently from 40f4d4c to 2f8cb7e Compare June 28, 2024 10:10
@fbricon
Copy link
Contributor

fbricon commented Jul 4, 2024

Tested it with lsp4ij and it failed:

2024-07-04 12:00:35,870 [ 371591] SEVERE - #c.i.i.p.PluginManager - 'void com.redhat.devtools.intellij.telemetry.core.service.TelemetryMessageBuilder.<init>(java.lang.ClassLoader)'
java.lang.NoSuchMethodError: 'void com.redhat.devtools.intellij.telemetry.core.service.TelemetryMessageBuilder.<init>(java.lang.ClassLoader)'
	at com.redhat.devtools.lsp4ij.internal.telemetry.RedHatTelemetryService.lambda$new$0(RedHatTelemetryService.java:32)
	at com.redhat.devtools.intellij.telemetry.core.util.Lazy.get(Lazy.java:27)
	at com.redhat.devtools.lsp4ij.internal.telemetry.RedHatTelemetryService.getMessageBuilder(RedHatTelemetryService.java:45)
	at com.redhat.devtools.lsp4ij.internal.telemetry.RedHatTelemetryService.send(RedHatTelemetryService.java:35)
	at com.redhat.devtools.lsp4ij.internal.telemetry.TelemetryManager$1.send(TelemetryManager.java:108)
	at com.redhat.devtools.lsp4ij.internal.telemetry.TelemetryManager$1.lambda$handleAdded$0(TelemetryManager.java:79)
	at java.base/java.util.Collections$SingletonSet.forEach(Collections.java:4905)
	at com.redhat.devtools.lsp4ij.internal.telemetry.TelemetryManager$1.handleAdded(TelemetryManager.java:79)

@fbricon
Copy link
Contributor

fbricon commented Jul 4, 2024

Can we avoid breaking API/ABI ?

@adietish
Copy link
Contributor Author

adietish commented Jul 4, 2024

@fbricon:

Can we avoid breaking API/ABI ?

This API breakage is caused by the fix for issue #824
We could keep the existing API but would keep plugins report the wrong exception. IMHO it is preferrable that plugins fix thing on their side.

@adietish
Copy link
Contributor Author

adietish commented Jul 4, 2024 •
edited
Loading

Can we avoid breaking API/ABI ?

Re-added the old constructor (marking it as deprecated for removal) which then made this work with lsp4ij. Testing the other plugins that we have.

@adietish adietish requested a review from sbouchet July 5, 2024 13:25
@adietish
Copy link
Contributor Author

adietish commented Jul 5, 2024

I tested the binary version of this plugin successfully with the following plugins:

  • kubernetes
  • quarkus
  • lsp4ij
  • openshift
  • rsp
  • dependency-analytics
  • tekton
  • knative

IMHO compatibility is no issue any more.

sbouchet
sbouchet approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally with openshift extension. LGTM

@adietish adietish mentioned this pull request Jul 18, 2024
Merged
@adietish adietish force-pushed the issue-82 branch 2 times, most recently from a107bad to 251b63b Compare July 18, 2024 13:35
@adietish adietish merged commit 920b439 into redhat-developer:main Jul 18, 2024
31 checks passed
@adietish adietish deleted the issue-82 branch July 18, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

@fbricon fbricon fbricon approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow limits to be configured
3 participants
@adietish @fbricon @sbouchet